Skip to content

add action group for AdminAdobeStockInsertRenditionImageFromGalleryFileSizeTest #30074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2020
Merged

add action group for AdminAdobeStockInsertRenditionImageFromGalleryFileSizeTest #30074

merged 2 commits into from
Sep 18, 2020

Conversation

engcom-Golf
Copy link
Contributor

@engcom-Golf engcom-Golf commented Sep 16, 2020 •
edited by sivaschenko
Loading

add action group for AdminAdobeStockInsertRenditionImageFromGalleryFileSizeTest
magento/adobe-stock-integration#1835

Fixed Issues (if relevant)

magento/adobe-stock-integration#1806

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2020

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sivaschenko
sivaschenko requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @engcom-Golf ! Please see my comment

...ento/MediaGalleryRenditions/Test/Mftf/ActionGroup/AdminRenditionsSetImageSizeActionGroup.xml Outdated
</arguments>
<magentoCLI command="config:set system/media_gallery_renditions/width {{width}}" stepKey="setWidth"/>
<magentoCLI command="config:set system/media_gallery_renditions/height {{height}}" stepKey="setHeight"/>
<magentoCLI command="cache:flush config" stepKey="cleanCache"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe clean cache is not needed for changing renditions size

@ghost ghost assigned sivaschenko Sep 16, 2020
@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8224 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko mentioned this pull request Sep 17, 2020
Merged
magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2020
@sidolov
ENGCOM-8224: add action group for AdminAdobeStockInsertRenditionImage…
0748aab 
…FromGalleryFileSizeTest #30074
@magento-engcom-team magento-engcom-team merged commit 9637de4 into magento:2.4-develop Sep 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2020

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryRenditions Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engcom-Golf @magento-engcom-team @sivaschenko