Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Add gift message attributes to Cart #7441

Merged
merged 4 commits into from
Jul 6, 2020
Merged

GraphQL: Add gift message attributes to Cart #7441

merged 4 commits into from
Jul 6, 2020

Conversation

keharper
Copy link
Contributor

Purpose of this pull request

This pull request (PR) adds attributes to the Cart object that were added in magento/magento2#27956

Affected DevDocs pages

and others

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc Community Docs impacted by community code contribution 2.4.1 labels Jun 23, 2020
@keharper keharper self-assigned this Jun 23, 2020
@keharper keharper changed the title Kh gift message order GraphQL: Add gift message attributes to Cart Jun 23, 2020
@keharper keharper requested review from rogyar and dobooth June 23, 2020 21:59
@keharper
Copy link
Contributor Author

@rogyar I added you as a reviewer because you're probably familiar with the development effort.

I'm aware that magento/magento2#27956 added more data types/attributes to the GiftMessage schema, but I'll hold off on adding them now,

@rogyar
Copy link
Contributor

rogyar commented Jul 3, 2020

Looks good. Please note that we have another PR with a similar purpose
#7476

@keharper keharper mentioned this pull request Jul 6, 2020
Closed
@keharper
Copy link
Contributor Author

keharper commented Jul 6, 2020

running tests

@keharper keharper merged commit 70e1fca into 2.4.1-develop Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_gift-message-order branch July 17, 2020 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

@dobooth dobooth dobooth approved these changes

Assignees

@rogyar rogyar

@keharper keharper

@dobooth dobooth

Labels
2.4.1 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keharper @rogyar @dobooth