GraphQL GiftMessageGraphQl add coverage for cart #27956

Usik2203 · 2020-04-23T15:52:19Z

Description (*)

This PR extends the existing GraphQl coverage by adding information about gift message to different types of cart items.

Please note, this PR does not cover the entire gift wrapping functionality but resolvers for the gift message. The rest of the git wrapping functionality will be delivered with the others PR

Note: These types were not extended because these types are not declared

 
type GiftCardCartItem {
    gift_message: GiftMessage @doc(description: "The entered gift message for the cart item")
}

type SalesItemInterface {
    gift_wrapping: GiftWrapping @doc(description: "The selected gift wrapping for the order item")
    gift_message: GiftMessage @doc(description: "The entered gift message for the order item")
}

type SalesTotalsInterface {
    gift_options: GiftOptionsPrices @doc(description: "The list of prices for the selected gift options")
}

This PR was mentioned for fixing failed static test related with composer.json file
#253

Related Pull Requests

#28072
#28105

Fixed Issues (if relevant)

GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout.

Manual testing scenarios (*)

You can use this query for manual testing. You should take maskedQuoteId from quote_id_mask table

{
    cart(cart_id: "maskedQuoteId") {
           gift_message {
               to
               from
               message
           }
      }
}

m2-assistant · 2020-04-23T15:52:22Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

rogyar

Hi @Usik2203. Thank you for your collaboration. Please, check my comments, adjust the code style and you may proceed with the test coverage.

Thank you!

rogyar · 2020-04-28T08:56:45Z

app/code/Magento/GiftMessageGraphQl/Model/Resolver/GiftMessage.php

+        $giftCartMessage = $this->cartRepository->get($cart->getId());
+
+        return [
+            'to' => $giftCartMessage->getRecipient(),


The recipient, sender and message may have null value. In this case, we need to make sure that we have no exception because all 3 values are required (and have Sring type) in the schema. I would recommend using the null coalesce operator and return empty string in case of no value. i.e.

$giftCartMessage->getSender() ?? ''

rogyar · 2020-04-28T08:58:09Z

app/code/Magento/GiftMessageGraphQl/composer.json

+      "magento/module-backend": "*",
+      "magento/module-catalog": "*",
+      "magento/module-checkout": "*",
+      "magento/module-customer": "*",


We need to make sure that we need all these dependencies

rogyar · 2020-04-28T09:00:26Z

app/code/Magento/GiftMessageGraphQl/Model/Resolver/GiftMessageItem.php

+/**
+ * Class GiftMessageItem
+ */
+class GiftMessageItem implements ResolverInterface


I'm not sure we should extend this PR with more functionality. Let's leave the gift messages for different cart item types in this PR and cover all other functionality (mutations, gift wrapping) in the following PRs

I have removed it from this PR, will do it in other PR

Usik2203 · 2020-04-29T15:27:56Z

@rogyar api-functional test was added for this PR.
Thank you for review.

app/code/Magento/GiftMessageGraphQl/README.md

app/code/Magento/GiftMessageGraphQl/composer.json

rogyar · 2020-05-04T06:55:04Z

Hi @Usik2203. Considering the fact that this solution will be tested manually on some stage, it would be very useful to have the corresponding section in the description filled out. It will be enough to post an example of the GraphQL request and some expected result.

Thank you!

Usik2203 · 2020-05-04T11:00:52Z

Hi @rogyar . I added example of query for manual testing in Manual testing scenarios area.
Thanks

eduard13 · 2020-05-20T19:50:20Z

@magento run Static Tests

Usik2203 · 2020-05-21T17:35:02Z

@magento run Static Tests

Usik2203 · 2020-05-22T08:57:06Z

@magento run Static Tests

Usik2203 · 2020-05-22T12:51:08Z

@magento run Static Tests

Usik2203 · 2020-05-22T13:17:17Z

@magento run Magento Health Index

Usik2203 · 2020-05-22T13:36:51Z

@magento run Static Tests

Usik2203 · 2020-05-22T14:04:54Z

@magento run Static Tests

magento-engcom-team · 2020-05-24T09:17:48Z

Hi @rogyar, thank you for the review.
ENGCOM-7587 has been created to process this Pull Request

paliarush · 2020-05-28T19:02:41Z

Verified that no new @api or interfaces were introduced in scope of this PR, so approval by the architecture team is not required.

engcom-Bravo · 2020-06-02T09:25:20Z

✔️ QA Passed

The GraphQL query

query {
  cart(
    cart_id: "8T3x445Ys2Scga6yWHAGVP9GYUPR8ua2"
  ) {
    gift_message {
      from
      message
      to
    }
  }
}

returns

{
  "data": {
    "cart": {
      "gift_message": {
        "from": "From",
        "message": "Message",
        "to": "To"
      }
    }
  }
}

m2-assistant · 2020-06-05T15:43:06Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added the Component: GiftMessageGraphQl label Apr 23, 2020

magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 23, 2020

ghost added the Progress: pending review label Apr 23, 2020

rogyar self-assigned this Apr 23, 2020

rogyar marked this pull request as draft April 23, 2020 17:25

rogyar self-requested a review April 28, 2020 07:57

rogyar requested changes Apr 28, 2020

View reviewed changes

rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Apr 28, 2020

ghost added Progress: needs update and removed Progress: pending review labels Apr 28, 2020

rogyar added the Award: category of expertise label Apr 28, 2020

Usik2203 force-pushed the feature-256 branch from 9f2a1f8 to db4fe3a Compare April 29, 2020 15:18

nrkapoor requested review from paliarush, lenaorobei, nrkapoor and rogyar May 1, 2020 14:51

This was referenced May 1, 2020

[WIP] Add GraphQl coverage for GiftMessage module for cart items #28070

Closed

[GraphQl] Gift Message coverage for cart item #28072

Merged

rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels May 4, 2020

rogyar requested changes May 4, 2020

View reviewed changes

app/code/Magento/GiftMessageGraphQl/README.md Outdated Show resolved Hide resolved

app/code/Magento/GiftMessageGraphQl/composer.json Show resolved Hide resolved

rogyar added the Award: test coverage label May 4, 2020

rogyar marked this pull request as ready for review May 4, 2020 06:53

rogyar changed the title ~~[WIP] GraphQL Checkout Add support for Gift Message during checkout~~ GraphQL Checkout Add support for Gift Message during checkout May 4, 2020

Usik2203 changed the title ~~GraphQL Checkout Add coverage for Gift Message~~ GraphQL GiftMessageGraphQl add coverage for cart May 20, 2020

rogyar approved these changes May 24, 2020

View reviewed changes

engcom-Bravo self-assigned this Jun 2, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jun 2, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jun 2, 2020

engcom-Kilo self-assigned this Jun 2, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jun 2, 2020

slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 5, 2020

slavvka added this to the 2.4.1 milestone Jun 5, 2020

nrkapoor linked an issue Jun 5, 2020 that may be closed by this pull request

GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout. #28519

Closed

nrkapoor added the Project: GraphQL label Jun 5, 2020

slavvka mentioned this pull request Jun 5, 2020

PHP Extension 0 must be loaded - XML Parse mistake? #253

Closed

magento-engcom-team merged commit ee50e37 into magento:2.4-develop Jun 5, 2020

lenaorobei added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jun 10, 2020

keharper mentioned this pull request Jun 23, 2020

GraphQL: Add gift message attributes to Cart magento/devdocs#7441

Merged

GraphQL GiftMessageGraphQl add coverage for cart #27956

GraphQL GiftMessageGraphQl add coverage for cart #27956

Uh oh!

Conversation

Usik2203 commented Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Note: These types were not extended because these types are not declared

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Uh oh!

m2-assistant bot commented Apr 23, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

rogyar Apr 28, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

rogyar Apr 28, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

rogyar Apr 28, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 commented Apr 29, 2020

Uh oh!

Uh oh!

Uh oh!

rogyar commented May 4, 2020

Uh oh!

Usik2203 commented May 4, 2020

Uh oh!

eduard13 commented May 20, 2020

Uh oh!

Usik2203 commented May 21, 2020

Uh oh!

Usik2203 commented May 22, 2020

Uh oh!

Usik2203 commented May 22, 2020

Uh oh!

Usik2203 commented May 22, 2020

Uh oh!

Usik2203 commented May 22, 2020

Uh oh!

Usik2203 commented May 22, 2020

Uh oh!

magento-engcom-team commented May 24, 2020

Uh oh!

paliarush commented May 28, 2020

Uh oh!

engcom-Bravo commented Jun 2, 2020

Uh oh!

m2-assistant bot commented Jun 5, 2020

Uh oh!

Uh oh!

Usik2203 commented Apr 23, 2020 •

edited

Loading