Move phpcs checks from magento2 to magento-coding-standard repo #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move files from Annotation folder
- Move files from Html folder
- Move files from Less folder
- WIP: Update ruleset.xml
sivaschenko
requested changes
Jul 28, 2021
There was a problem hiding this comment.
Thanks for the PR @loginesta .
The remaining work would be:
- Fix all the failing tests
- Add all the rules from the rulesets specified in the comments
| @@ -580,4 +580,13 @@ | |||
| <severity>5</severity> | |||
| <type>warning</type> | |||
| </rule> | |||
| <rule ref="Magento2.Annotation"> | |||
There was a problem hiding this comment.
All the rules from the following files should be added as well:
- https://github.com/magento/magento2/blob/2.4-develop/dev/tests/static/testsuite/Magento/Test/Html/_files/html/ruleset.xml
- https://github.com/magento/magento2/blob/2.4-develop/dev/tests/static/testsuite/Magento/Test/Less/_files/lesscs/ruleset.xml
- https://github.com/magento/magento2/blob/2.4-develop/dev/tests/static/framework/Magento/ruleset.xml
There was a problem hiding this comment.
These ones are already there, EndFileNewline, LineEndings and DisallowTabIndent.
Just adding the ones missing
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
ihor-sviziev
requested changes
Jul 29, 2021
There was a problem hiding this comment.
Hi @loginesta,
Could you also cover your change with tests?
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
- Add other rules from previous ruleset files on Magento
|
@ihor-sviziev we are moving a bulk of tests from magento2 repository to magento-testing-coverage (that is the first part). Considering the volume of tests to be moved, limited resources and missing test coverage on magento2 repository we would like to deffer test coverage for the Sniffs moved from magento2 in bulk. |
- Add missing comment block
| @@ -128,8 +128,7 @@ private function getArgumentListClosePointer($openParenthesisPointer, array $tok | |||
| } | |||
|
|
|||
| /** | |||
| * Seeks the next available {@link T_OPEN_PARENTHESIS} token that comes directly after <var>$stackPointer</var>. | |||
| * token. | |||
| * Seeks the next available {@link T_OPEN_PARENTHESIS} token that comes directly after <var>$stackPointer</var> token. | |||
There was a problem hiding this comment.
Suggested change
| * Seeks the next available {@link T_OPEN_PARENTHESIS} token that comes directly after <var>$stackPointer</var> token. | |
| * Find the argument list open pointer | |
| * | |
| * Seeks the next available {@link T_OPEN_PARENTHESIS} token | |
| * that comes directly after <var>$stackPointer</var> token. |
| @@ -68,8 +68,7 @@ public function process(File $phpcsFile, $stackPtr) | |||
| } | |||
|
|
|||
| /** | |||
| * Seeks the next available token of type {@link T_CLOSE_CURLY_BRACKET} in <var>$tokens</var> and returns its | |||
| * pointer. | |||
| * Seeks the next available token of type {@link T_CLOSE_CURLY_BRACKET} in <var>$tokens</var> and returns its pointer. | |||
There was a problem hiding this comment.
Suggested change
| * Seeks the next available token of type {@link T_CLOSE_CURLY_BRACKET} in <var>$tokens</var> and returns its pointer. | |
| * Find the closing curly bracket pointer | |
| * | |
| * Seeks the next available token of type {@link T_CLOSE_CURLY_BRACKET} | |
| * in <var>$tokens</var> and returns its pointer. |
| @@ -81,10 +80,9 @@ private function getClosingCurlyBracketPointer($startPointer, array $tokens) | |||
| } | |||
|
|
|||
| /** | |||
| * Seeks the next available token of type {@link T_OPEN_CURLY_BRACKET} in <var>$tokens</var> and returns its | |||
| * pointer. | |||
| * Seeks the next available token of type {@link T_OPEN_CURLY_BRACKET} in <var>$tokens</var> and returns its pointer. | |||
There was a problem hiding this comment.
Suggested change
| * Seeks the next available token of type {@link T_OPEN_CURLY_BRACKET} in <var>$tokens</var> and returns its pointer. | |
| * Find the opening curly bracket pointer | |
| * | |
| * Seeks the next available token of type {@link T_OPEN_CURLY_BRACKET} | |
| * in <var>$tokens</var> and returns its pointer. |
- Format multi-line comments
sivaschenko
approved these changes
Jul 30, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 30, 2023
…o-coding-standard-438 [Imported] Auto-fix `Magento2.PHP.ShortEchoSyntax.ShortEchoTag`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.magento.com/browse/AC-201 Move phpcs checks from magento2 to magento-coding-standard repo