#210: Fixed HtmlDirectiveSniff.php from causing the Fatal Error for c…

[asheem-patro]

…lass not found

Fixes #210

[ihor-sviziev]

Hi @asheem-patro,
Could you provide some steps to reproduce?

[asheem-patro]

Hi @ihor-sviziev

Install the magento-coding-standards in some different directory other than the Magento root. Then run the phpcs using /var/www/html/magento-coding-standard/vendor/bin/phpcs --standard=Magento2 app/code/

[asheem-patro]

@ihor-sviziev - \Magento\Framework\Filter\Template this framework class has been used inside \Magento2\Sniffs\Html\HtmlDirectiveSniff to use some constants. Due to which we are getting the class not found error. It is having a problem in using the magento-coding-standard on the bitbucket pipelines.

Please let me know if you want some more clarifications.

[ihor-sviziev]

@asheem-patro,
Interesting... for some reason, it's not failing when we're running it inside the coding standard repo...
https://github.com/magento/magento-coding-standard/runs/3218975370?check_suite_focus=true

I think it has to fail. We should fix that at first, and later on accept your PR :)

[asheem-patro]

@ihor-sviziev - I am also wondering the same thing. It still fails for me without this fix. Complete error with Stack trace is in below screenshot.

[ihor-sviziev]

Approved ✔

Changes looks good.

[ihor-sviziev]

Note: I just checked - this sniff was added in #209 and wasn't covered with any tests. That's why the tests are not failing.

This PR fixes #210

[sivaschenko]

@magento import pr to magento-commerce/magento-coding-standard

[magento-engcom-team]

@sivaschenko the pull request successfully imported.