MC-30776: Improve Performance of SVC #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rrego6
force-pushed
the
MC-30776
branch
4 times, most recently
from
d2eb18e to
f672d12
Compare
roribio
suggested changes
Mar 5, 2020
composer.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "magento/magento-semver", | |||
| "description": "Magento semantic version checker", | |||
| "version": "3.0.0", | |||
| "version": "4.0.0", | |||
There was a problem hiding this comment.
Release 4.0.0 has already gone out. Please bump this to 5.0.0
| @@ -10,10 +10,11 @@ | |||
| "require": { | |||
| "php": "~7.1.3||~7.2.0||~7.3.0", | |||
| "phpstan/phpdoc-parser": "^0.3.5", | |||
| "symfony/console": "~4.4.0", | |||
| "symfony/console": "~4.1.0||~4.4.0", | |||
There was a problem hiding this comment.
These changes have gone out as part of v4.0.0. Please rebase your feature branch on develop.
Thanks!
- Added nikic/php-parser as hard dependency in composer - Improved performance of DependencyMap creation. - Remove stms when adding ClassMethod nodes to dependency tree - Added better doc comments - Addeed more aggresive AbstractApiVisitor traversal termination - Refactored code to use switch statements
- bump of composer svc version - regenerated composer.lock with php 7.1
|
@Rrego6 This is ready to go except the two items I outlined above. Let me know once that's done so I can merge it in. Thanks! |
|
https://fisheye.corp.magento.com/cru/CR-MAGETWO-50036 |
roribio
added a commit
that referenced
this pull request
Mar 12, 2020
* MC-30776: Improve Performance of SVC (#28) - Added nikic/php-parser as hard dependency in composer - Improved performance of DependencyMap creation. - Remove stms when adding ClassMethod nodes to dependency tree - Added better doc comments - Addeed more aggresive AbstractApiVisitor traversal termination - Refactored code to use switch statements Co-authored-by: Raoul Rego <[email protected]>
roribio
pushed a commit
that referenced
this pull request
Jun 18, 2020
* SVC Release 5.0.0 (#32) * MC-30776: Improve Performance of SVC (#28) - Added nikic/php-parser as hard dependency in composer - Improved performance of DependencyMap creation. - Remove stms when adding ClassMethod nodes to dependency tree - Added better doc comments - Addeed more aggresive AbstractApiVisitor traversal termination - Refactored code to use switch statements Co-authored-by: Raoul Rego <[email protected]> * MC-33067: Update magento2-infrastructure composer dependencies - Add PHP 7.4 to composer.json * Update magento-semver to be compatible with PHP7.4 (#33) * MC-33156: Update magento-semver to be compatible with PHP7.4
fascinosum
added a commit
that referenced
this pull request
Sep 3, 2021
Has been added compatibility with PHP 8 to `magento/semver`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Add performance improvements to SVC during creation of DependencyMap and creation of static analyzers. I also remove the method stmts from the method nodes being stored in the dependency map. This is to fix the memory issues when comparing files.
- Added nikic/php-parser as hard dependency in composer
- Improved performance of DependencyMap creation.
- Remove stms when adding ClassMethod nodes to dependency tree
- Added better doc comments
- Addeed more aggresive AbstractApiVisitor traversal termination
- Refactored code to use switch statements
Fixed Issues (if relevant)
https://jira.corp.magento.com/browse/MC-30776
Manual testing scenarios (*)
Compared results with running original svc branch using 2.3-develop and 2.4-develop.
Both logs are equivalent. The only difference is that this branch adds some "Method implementation changed" PATCH changes. This is explained in AbstractApiVisitor::enterNode comment.
Questions or comments
Contribution checklist (*)