Skip to content

Update magento-semver to be compatible with PHP7.4 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Conversation

xmav
Copy link
Contributor

@xmav xmav commented Apr 24, 2020

Description (*)

Add support of PHP 7.3 & PHP 7.4 syntax

Manual testing scenarios (*)

Changes were verified using Jenkins builds on large changeset showing identical results comparable to version 5.0.0

Questions or comments

Due to updated dependency lowest PHP version is 7.2.29.
https://packagist.org/packages/tomzx/php-semver-checker#v0.14.0

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@roribio roribio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@roribio roribio merged commit cf94055 into MC-33066 Apr 24, 2020
@fascinosum fascinosum deleted the MC-33156 branch June 17, 2020 14:54
roribio pushed a commit that referenced this pull request Jun 18, 2020
* SVC Release 5.0.0 (#32)

* MC-30776:  Improve Performance of SVC (#28)

- Added nikic/php-parser as hard dependency in composer
- Improved performance of DependencyMap creation.
- Remove stms when adding ClassMethod nodes to dependency tree
- Added better doc comments
- Addeed more aggresive AbstractApiVisitor traversal termination
- Refactored code to use switch statements

Co-authored-by: Raoul Rego <[email protected]>

* MC-33067: Update magento2-infrastructure composer dependencies
- Add PHP 7.4 to composer.json

* Update magento-semver to be compatible with PHP7.4 (#33)

* MC-33156: Update magento-semver to be compatible with PHP7.4
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 24, 2022
AC-3684: Release magento components with symfony 5.4 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants