Skip to content

Minicart product name - not covered cases #29075

Closed
@Januszpl

Description

@Januszpl

Preconditions (*)

Magento 2.3.5, 2.4

Related to: #13802

Steps to reproduce (*)

  1. Add product with special characters to cart
  2. remove ifnot condition (or trigger usage of it in other way) in template
    <div class="product-item-details">
    <strong class="product-item-name">
    <!-- ko if: product_has_url -->
    <a data-bind="attr: {href: product_url}, html: product_name"></a>
    <!-- /ko -->
    <!-- ko ifnot: product_has_url -->
    <!-- ko text: product_name --><!-- /ko -->
    <!-- /ko -->
    </strong>
  3. open minicart

Issue:
If you use text: product_name in

when product name has special characters like double quotes it will render them wrongly.

By default in most cases template will use html binding if product has url.

But this should be replaced by <span data-bind="html: product_name"></span> or removed.

Expected result (*)

Actual result (*)


Severity: S2/3 ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CheckoutFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.3.5Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S2Major restrictions or short-term circumventions are required until a fix is available.help wanted

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions