-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #13652. Mini cart - fix issue in product title with special chars. #13802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13652. Mini cart - fix issue in product title with special chars. #13802
Conversation
@afirlejczyk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @afirlejczyk thank you for this pull request. Could you please have a look through the docs on adding new constructor arguments. http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#adding-a-constructor-parameter For your example I think that escaper should be an optional parameter and also be the last item in the constructor so as to not break any other code that already extends this class.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the new constructor parameter to make our guidelines http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#adding-a-constructor-parameter
Hi @dmanners I've updated the code, but I have one question. I also update constructor in classes which extends DefaultItem.php class (app/code/Magento/GroupedProduct/CustomerData/GroupedItem.php, app/code/Magento/ConfigurableProduct/CustomerData/ConfigurableItem.php) but in this case it is not necessary. I don't know which solution would be best. |
Hi @afirlejczyk thank you for this update. I would update all the constructors like you have done. This means in a future major release we can update them so they are required constructor and the code will already be in place to handle such a change. |
Hi @dmanners, thank you for the review. |
Fix showing product name with special chars in mini cart.
Description
This code was used in html template to show product name
I replaced it with:
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist