[Sales] Missing relation data when reorder

[Nuranto]

Preconditions and environment

• Magento version 2.4.5-p1
• PHP 8.1

Steps to reproduce

1. Place an order
2. Reorder that order

Expected result

• relation_child_id and relation_child_real_id are set in parent order row. A link is diplayed on parent order view to new order.
  
• relation_parent_id and relation_parent_real_id are set in child order row. A link is diplayed on child order view to parent order.

Actual result

• relation_child_id and relation_child_real_id are not set in parent order row. No link is diplayed on parent order view to new order.
• relation_parent_id and relation_parent_real_id are not set in child order row. No link is diplayed on child order view to parent order.

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hi @Nuranto ,
Thank you for reporting and collaboration. Verified the behavior on Magento 2.4-develop instance and is reproducible. But however, as per Magento docs this seems to be expected behavior. As per Magento documentation, no link to view parent order / child order from View Order page is displayed. Kindly recheck the docs and provide supporting docs/ proofs to consider this as valid bug.
Thank you.

[Nuranto]

Hi @engcom-November,

Ok I'm sorry, the links to previous/new on order page view I was talking about, are on backend order view. I should have been more specific.

Updated steps :

1. Place an order
2. Reorder that order from backend
3. Check on backend order page view

However, there is no documentation about that neither: There's no screenshot on the doc of that page after reorder.

However, the fields relation_* do exists in sales_order table, the setters and getters on OrderInterface do exist too, and the admin template does exist and work well when these fields are set (You can try by set those fields manually in database).

magento2/app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml

Lines 75 to 94 in 4a41ec4

	<?php if ($order->getRelationChildId()) : ?>
	<tr>
	<th><?= $block->escapeHtml(__('Link to the New Order')) ?></th>
	<td>
	<a href="<?= $block->escapeUrl($block->getViewUrl($order->getRelationChildId())) ?>">
	<?= $block->escapeHtml($order->getRelationChildRealId()) ?>
	</a>
	</td>
	</tr>
	<?php endif; ?>
	<?php if ($order->getRelationParentId()) : ?>
	<tr>
	<th><?= $block->escapeHtml(__('Link to the Previous Order')) ?></th>
	<td>
	<a href="<?= $block->escapeUrl($block->getViewUrl($order->getRelationParentId())) ?>">
	<?= $block->escapeHtml($order->getRelationParentRealId()) ?>
	</a>
	</td>
	</tr>
	<?php endif; ?>

[engcom-November]

Thank you for the response @Nuranto ,
Verified the issue again on Magento 2.4-develop instance with updated steps and the issue is reproducible on Admin Backend.
"Link to the Previous Order" is initially not displayed by default after reorder (relation_parent_id, relation_parent_real_id values in sales_order DB table are NULL) in Admin - Order details page but by manually updating relation_parent_id, relation_parent_real_id values in sales_order DB table, "Link to the previous order" is getting displayed on UI
However, as per Magento docs no such link is mentioned as expected behavior in Admin Order details page. Please provide your inputs on whether we need to still consider this as an issue as per Magento docs or enhancement / feature request to include the link in Admin Order details page.


Thank you.

[Nuranto]

Hi @engcom-November,

My point of view is that if the code exists, the schema exists and the template exists but the result of all that is wrong... then it should be considered as an issue. The feature exists, it just doesn't work.
The docs cannot be exhaustive, I mean, if I follow your link, I can't see "Unhold" button either. Does it means it would be a feature request if that button doesn't show up after holding an oder ?

We maybe should add screenshots after step 5 (at the end of page) here : https://experienceleague.adobe.com/docs/commerce-admin/stores-sales/shopper-tools/reorders-allow.html?lang=en since it's missing

[engcom-November]

Thank you for the response @Nuranto . Agree with you and considering this as an issue. Updating the description as per ref comment and confirming the issue.