magento/magento2#37028: [Sales] Missing relation data when reorder

[KrasnoshchokBohdan]

• fix createOrder method to understand that order is reordered.

Description (*)

Change \Magento\Sales\Model\AdminOrder\Create::createOrder to understand that order is reordered, before changes part of this method didn't work because it tries to get order from session, now it looks to 'reordered' parameter that added in \Magento\Sales\Model\AdminOrder\Create::initFromOrder

Related Pull Requests

--

Fixed Issues (if relevant)

1. Fixes [Sales] Missing relation data when reorder #37028

Manual testing scenarios (*)

1. Place an order
2. Reorder that order from backend
3. Check on backend order page view

Before fix:
relation_child_id and relation_child_real_id are not set in parent order row. No link is diplayed on parent order view to new order.
relation_parent_id and relation_parent_real_id are not set in child order row. No link is diplayed on child order view to parent order.

After fix:
relation_child_id and relation_child_real_id are set in parent order row. A link is diplayed on parent order view to new order.
relation_parent_id and relation_parent_real_id are set in child order row. A link is diplayed on child order view to parent order.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[DanK894]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[KrasnoshchokBohdan]

Failed tests seems flaky to me

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run WebAPI Tests,Unit Tests,Integration Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run WebAPI Tests,Unit Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

@magento run WebAPI Tests,Unit Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

Failed test does not seems to related to PR.
Hence moving in merge in progress

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[KrasnoshchokBohdan]

@magento run Integration Tests, Unit Tests, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[KrasnoshchokBohdan]

@magento run Integration Tests, Unit Tests, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[atIOCrON]

We updated to v2.4.7-p1 where this fix was pushed and it has caused problems because the "Reorder" button should not cause the new order to link to the previous one as suggested here.

We've been using Magento since 2009 and this was never the behaviour of the reorder button.

The link on the admin order page to a new order is only when you "Edit" an order. In that case, there should be a link because the orders are the same, you are editing one which cancels the first and makes the second, however, the reorder button is just a shortcut to place a brand new order for a client, it has nothing to do with the previous order.

This "fix" should be removed, it makes no sense at all.

[rhengeveldbordex]

We are encountering the same issue! All reorders are now being incorrectly linked to the original orders. I completely agree that this "fix" should be reverted. It’s frustrating and disrupts the intended functionality of the reorder button, which should create a brand new order without any ties to the previous one.