Skip to content

[Backport] Fix #13652. Mini cart - fix issue in product title with special chars. #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ihor-sviziev
Copy link
Contributor

Original Pull Request

#13802
Fix showing product name with special chars in mini cart.

Description

This code was used in html template to show product name

<a data-bind="attr: {href: product_url}, text: product_name"></a>

I replaced it with:

<a data-bind="attr: {href: product_url}, html: product_name"></a>

Fixed Issues (if relevant)

  1. Issue in product title with special chars in mini cart #13652: Issue in product title with special chars in mini cart

Manual testing scenarios

  1. Create a product titled Fusion Backpack ™
  2. Go to frontend, the product title comes up correctly as Fusion Backpack ™ then add it to cart
  3. Open the mini cart - product title should be display correctly as Fusion Backpack ™

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@ihor-sviziev ihor-sviziev deleted the 2.2-develop-PR-port-13802 branch September 20, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants