-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix issue 19492 - Catalog Product - Customizable Options label alignment issue #19493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 19492 - Catalog Product - Customizable Options label alignment issue #19493
Conversation
Hi @speedy008. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@speedy008 could you please make one commit instead of four? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@speedy008 thanks for the contribution! Please remove the blank line and squash changes to a single commit.
@@ -671,9 +671,12 @@ | |||
margin: 0; | |||
opacity: 1; | |||
position: static; | |||
text-align: left; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the blank line
Hi @sivaschenko |
@speedy008 thanks for the update, can you also take a look at #19493 (comment) comment. Please squash commits into a single one |
38c4fcf
to
2d75bd2
Compare
2d75bd2
to
f63ed89
Compare
Hi @VladimirZaets |
Hi @sivaschenko, thank you for the review. |
… label alignment issue #19493
Hi @speedy008. Thank you for your contribution. |
Description (*)
Magento 2.3-develop
Catalog Product - Customizable Options label alignment issue
Fixed Issues (if relevant)
1.#19492 : Catalog Product - Customizable Options label alignment issue
Manual testing scenarios (*)
1.N/A
Contribution checklist (*)