Skip to content

Fix issue 19492 - Catalog Product - Customizable Options label alignment issue #19493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Dec 1, 2018

Description (*)

Magento 2.3-develop
Catalog Product - Customizable Options label alignment issue

Fixed Issues (if relevant)

1.#19492 : Catalog Product - Customizable Options label alignment issue

Manual testing scenarios (*)

1.N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

orlangur commented Dec 1, 2018

@speedy008 could you please make one commit instead of four?

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speedy008 thanks for the contribution! Please remove the blank line and squash changes to a single commit.

@sivaschenko sivaschenko self-assigned this Dec 2, 2018
@@ -671,9 +671,12 @@
margin: 0;
opacity: 1;
position: static;
text-align: left;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the blank line

@speedy008
Copy link
Contributor Author

Hi @sivaschenko
I have updated code kindly review it.

@sivaschenko
Copy link
Member

sivaschenko commented Dec 5, 2018

@speedy008 thanks for the update, can you also take a look at #19493 (comment) comment. Please squash commits into a single one

@speedy008
Copy link
Contributor Author

Hi @VladimirZaets
I have Squash 4 commit to one.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3659 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants