Skip to content

Fixed Catalog Product - Customizable Options label alignment issue #19496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed Catalog Product - Customizable Options label alignment issue #19496

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2018

Description (*)

Magento 2.3-develop
Catalog Product - Customizable Options 2nd and third label alignment issue

Fixed Issues (if relevant)

  1. Catalog Product - Customizable Options label alignment issue #19492: Catalog Product - Customizable Options label alignment issue
  2. ...

Manual testing scenarios (*)

1.Not Required for designing alignment issue
2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 1, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @emiprotech. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emiprotech please fix branch history (looks like this one was based on 2.2-develop while it should on 2.3-develop).

@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop December 2, 2018 10:01
@sivaschenko
Copy link
Member

@emiprotech thank you for the contribution! This pull request seems to be a duplicate to #19493 that is already opened for 2.3-develop , if it is, please close it.
cc @speedy008

@ghost
Copy link
Author

ghost commented Dec 3, 2018

@sivaschenko,
My changes and exsting pull request changes are different. both changes are working. I am closing this pull request because of code conflicting in my pull request. I have submitted new pull request to resolve confiction issue.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants