Skip to content

Issue 25253 #25259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Issue 25253 #25259

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2019

Description (*)

After removing the full text search keyword the selected records and count mismatches. Which is fixed now.

Fixed Issues (if relevant)

  1. UI Component grid indicates a wrong number of selections when removin… #25253:UI Component grid indicates a wrong number of selections when removing keyword search

Manual testing scenarios (*)

Setup some vanilla Magento
Login to the backend
Create 3 customers: 'One One', 'Two Two' and 'Three Three':
In the 'Search by keyword' box, enter 'one' and search
In the first column, choose the 'Select All' option
Notice that one record is selected:
I. Remove the 'one' keyword search by pressing the 'x' icon to the right of it.
II. Notice that it now says that one record is selected, but visually all records have a checkmark:
Select Actions => Delete
Notice that it says it will remove 1 record:
Press OK
Notice that it now removed all records (3) instead of the 1 it claimed to delete before
Press OK
Notice that it now removed all records (3) instead of the 1 it claimed to delete before

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Prabhat Rawat added 2 commits October 24, 2019 11:41
@ghost ghost requested a review from DrewML as a code owner October 24, 2019 06:19
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2019

Hi @prabhatrawat-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2019

Hi @prabhatrawat-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost deleted the issue-25253 branch October 30, 2019 09:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant