UI Component grid indicates a wrong number of selections when removin…

[ghost]

wrong number of selections(selected records) in ui component grid #24348

Description (*)

After removing the full text search keyword the selected records and count mismatches. Which is fixed now.

Fixed Issues (if relevant)

1. fixes UI Component grid indicates a wrong number of selections when removing keyword search #24348:UI Component grid indicates a wrong number of selections when removing keyword search

Manual testing scenarios (*)

1. Setup some vanilla Magento
2. Login to the backend
3. Create 3 customers: 'One One', 'Two Two' and 'Three Three':
4. In the 'Search by keyword' box, enter 'one' and search
5. In the first column, choose the 'Select All' option
6. Notice that one record is selected:
   I. Remove the 'one' keyword search by pressing the 'x' icon to the right of it.
   II. Notice that it now says that one record is selected, but visually all records have a checkmark:
7. Select Actions => Delete
8. Notice that it says it will remove 1 record:
9. Press OK
10. Notice that it now removed all records (3) instead of the 1 it claimed to delete before
11. Press OK
12. Notice that it now removed all records (3) instead of the 1 it claimed to delete before

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @prabhatrawat-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[krzksz]

Hey @prabhatrawat-webkul, please take a look at the failing tests.

[VladimirZaets]

@magento run all tests

[sidolov]

@magento run all tests

[sidolov]

@prabhatrawat-webkul solution looks good to me! Could you please fix JS static test failures and cover changes with automated test? Thank you!

[engcom-Charlie]

HI, @prabhatrawat-webkul Could you please fix Static tests failures and cover changes with an automated test?
Thank you.

[gabrieldagama]

Hi @prabhatrawat-webkul, thanks for your contribution. After looking at the issue and the possible solutions we've decided to proceed with this PR #29968 that aims to fix the same issue.

The approach that was chosen was to preserve the same behavior that we have with filters. So when a search tag is removed from filters the previous selection becomes invalid and it is dismissed. As result, we have the same behavior across multiple functionalities on the grid.

I will be closing this PR but feel free to reopen it anytime.

[m2-assistant]

Hi @prabhatrawat-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.