Add validation phone field on checkout page #27537

Usik2203 · 2020-04-01T16:52:53Z

Description (*)

This PR adds validation for phone field on checkout page

Before

After

Resolved issues:

resolves [Issue] Add validation phone field on checkout page #28800: Add validation phone field on checkout page

m2-assistant · 2020-04-01T16:52:55Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Usik2203 · 2020-04-01T16:55:32Z

@magento give me test instance

magento-engcom-team · 2020-04-01T16:55:33Z

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-04-01T16:56:16Z

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-27537.instances.magento-community.engineering/admin_98d6
Login: 97f5d420 Password: 30b32e51d22f
Instance will be terminated in up to 3 hours.

krzksz

Hey, thank you for your contribution! Can you please address my comments to the code?

krzksz · 2020-04-04T09:21:28Z

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

+        'validate-phone': [
+            function (value) {
+                return utils.isEmptyNoTrim(value) ||
+                    /^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]*$/.test(value);


According to my tests, the slash has to be escaped:

Suggested change

/^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]*$/.test(value);

/^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\.\/0-9]*$/.test(value);

I have fixed it.
Thank You for advice

krzksz · 2020-04-04T09:22:04Z

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

+                return utils.isEmptyNoTrim(value) ||
+                    /^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]*$/.test(value);
+            },
+            $.mage.__('Please enter a valid phone number. For example (123) 456-7890, 123-456-7890, +(123)4567890, +1234567890')


Static tests are failing because of this line length, can you please break it into multiple lines?

Fixed by add //eslint-disable-line max-len on the end string
like on the others cases in this file
Thanks for advice

Usik2203 · 2020-04-17T14:17:31Z

Hi @krzksz
Any news about this PR ?
Could I kindly ask you to check it If you will have free slot of time
Thank you a lot !

magento-engcom-team · 2020-04-18T20:40:42Z

Hi @krzksz, thank you for the review.
ENGCOM-7457 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Delta · 2020-04-22T11:59:45Z

Hi @krzksz . You add label "Needs update". Is there any changes need to be done ?

krzksz · 2020-04-22T12:02:42Z

@engcom-Delta Missclick, my bad.

Usik2203 · 2020-06-29T19:00:14Z

@magento run all tests

Usik2203 · 2020-06-30T18:58:47Z

@magento run all tests

magento-engcom-team · 2020-07-06T07:22:47Z

Hi @krzksz, thank you for the review.
ENGCOM-7457 has been created to process this Pull Request

engcom-Delta · 2020-07-13T12:46:47Z

✔️ QA passed
Result with fix:

engcom-Echo · 2020-07-22T11:11:28Z

@magento run all tests

m2-assistant · 2020-08-01T09:19:55Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

sdzhepa · 2020-08-19T18:31:21Z

This PR will be reverted due to issue found during regression testing

More details in the description: #29682
and qa comment: #29682 (comment)

Validate phone field on checkout page

c54b8f3

ghost added the Progress: pending review label Apr 1, 2020

magento-engcom-team added Area: Frontend Component: Checkout Component: Ui Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 1, 2020

krzksz suggested changes Apr 4, 2020

View reviewed changes

ghost assigned krzksz Apr 4, 2020

ghost added Progress: needs update and removed Progress: pending review labels Apr 4, 2020

add slash and fix static issue

196e423

krzksz approved these changes Apr 18, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 18, 2020

krzksz added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: needs update and removed Progress: ready for testing labels Apr 18, 2020

engcom-Delta self-assigned this Apr 22, 2020

krzksz removed the Progress: needs update label Apr 22, 2020

ghost added the Progress: testing in progress label Apr 22, 2020

Update some phones

15ceda0

Fix phone

a692863

engcom-Echo requested a review from krzksz July 6, 2020 07:17

krzksz approved these changes Jul 6, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jul 6, 2020

magento-engcom-team added Component: Customer and removed Component: Ui labels Jul 6, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 13, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 13, 2020

engcom-Delta added QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 13, 2020

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 22, 2020

added testCaseId

95be243

ghost added Progress: accept and removed Progress: extended testing labels Jul 24, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020

ENGCOM-7457: Add validation phone field on checkout page #27537

20e4e07

magento-engcom-team merged commit 1eb8536 into magento:2.4-develop Aug 1, 2020

engcom-Kilo self-assigned this Aug 19, 2020

engcom-Charlie mentioned this pull request Aug 19, 2020

Revert "Add validation phone field on checkout page" #29682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add validation phone field on checkout page #27537

Add validation phone field on checkout page #27537

Usik2203 commented Apr 1, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Apr 1, 2020

Usik2203 commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

krzksz left a comment

krzksz Apr 4, 2020

Usik2203 Apr 5, 2020

krzksz Apr 4, 2020

Usik2203 Apr 5, 2020

Usik2203 commented Apr 17, 2020 •

edited

Loading

magento-engcom-team commented Apr 18, 2020

engcom-Delta commented Apr 22, 2020

krzksz commented Apr 22, 2020

Usik2203 commented Jun 29, 2020

Usik2203 commented Jun 30, 2020

magento-engcom-team commented Jul 6, 2020

engcom-Delta commented Jul 13, 2020

engcom-Echo commented Jul 22, 2020

m2-assistant bot commented Aug 1, 2020

sdzhepa commented Aug 19, 2020

	/^[+][(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]$/.test(value);
	/^[+][(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\.\/0-9]$/.test(value);

Add validation phone field on checkout page #27537

Add validation phone field on checkout page #27537

Conversation

Usik2203 commented Apr 1, 2020 • edited by m2-assistant bot Loading

Description (*)

Before

After

Resolved issues:

m2-assistant bot commented Apr 1, 2020

Usik2203 commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

krzksz left a comment

Choose a reason for hiding this comment

krzksz Apr 4, 2020

Choose a reason for hiding this comment

Usik2203 Apr 5, 2020

Choose a reason for hiding this comment

krzksz Apr 4, 2020

Choose a reason for hiding this comment

Usik2203 Apr 5, 2020

Choose a reason for hiding this comment

Usik2203 commented Apr 17, 2020 • edited Loading

magento-engcom-team commented Apr 18, 2020

engcom-Delta commented Apr 22, 2020

krzksz commented Apr 22, 2020

Usik2203 commented Jun 29, 2020

Usik2203 commented Jun 30, 2020

magento-engcom-team commented Jul 6, 2020

engcom-Delta commented Jul 13, 2020

engcom-Echo commented Jul 22, 2020

m2-assistant bot commented Aug 1, 2020

sdzhepa commented Aug 19, 2020

Usik2203 commented Apr 1, 2020 •

edited by m2-assistant bot

Loading

Usik2203 commented Apr 17, 2020 •

edited

Loading