Skip to content

Revert "Add validation phone field on checkout page" #29682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Aug 19, 2020

Reverts #27537

This PR has been reverted due to a regression bug for 2.4.1 MC-36812. These changes was Rejected by Product Manager

Explanation:

The input validation on the customer and customer address attributes should be configured in Admin in attribute settings. There is currently possible to configure only numbers and - symbol input validation and all the validations are extensible so if merchants want to add any other validation rules which are not available out of the box they can customize them by themselves.

This functionality is already available in Admin Panel(UI) for Commerce edition(EE). It has section "Customer Address Attributes"
2020-08-18_16-44

In Open Sorce(CE) edition, there is no UI in Admin Panel for this but it can be easily done with minimal dev assistance.

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie requested a review from sidolov August 19, 2020 14:52
@engcom-Charlie
Copy link
Contributor Author

@sidolov Please review this PR.

@sidolov sidolov added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8032 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Precondition:
Magento 2.4-develop (EE)
Create a category;
Create Product and assign to category;

Manual testing scenario:

  1. Go to Admin -> Stores -> Attributes -> Customer Address and select telephone attribute for edit;
  2. Make sure that Input Validation is set to None

2020-08-19_19-17
3. Go to Storefront;
4. Add product to cart;
5. Click on Proceed to Checkout button;
6. Fill all required fields;

Before: ✖️ Please enter a valid phone number. For example (123) 456-7890 or 123-456-7890.

2020-08-19_19-09

After: ✔️ No validation for Phone Number field

2020-08-19_19-24

Also was checked on the CE and B2B versions of Magento, and everything works as previous (expected).

@ihor-sviziev
Copy link
Contributor

@engcom-Charlie @sidolov thank you for making revert publicly with sharing reason why it was reverted!

@engcom-Kilo engcom-Kilo self-assigned this Aug 20, 2020
@engcom-Kilo engcom-Kilo added QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@okorshenko okorshenko deleted the revert-27537-validate-phone-field-on-checkout branch August 25, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Checkout Component: Customer Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants