Skip to content

Add collapsible nav in customer account theme blank #28177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2020
Merged

Add collapsible nav in customer account theme blank #28177

merged 2 commits into from
Sep 30, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented May 10, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This additionals aims to bring collapsible nav in mobile view for blank theme magento
This improvement accessibility for user when go around links in mobile (with collapsible nav)
Desktop still remain same UI like before
Move collapsible nav from luma theme to blank theme

Related Pull Requests

Fixed Issues (if relevant)

No issue

Manual testing scenarios (*)

Login to customer account page in mobile
Navigation should show in top and collapsible on touch for visible links navigate to another page

Questions or comments

Before results
-Mobile
customer_nav_mobile

-Desktop
customer_nav_desktop

After results
-Mobile
customer_nav_mobile_update

-Desktop
Remain like before change

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add collapsible nav in customer account theme blank #30237: Add collapsible nav in customer account theme blank

@m2-assistant
Copy link

m2-assistant bot commented May 10, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented May 23, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 18, 2020

@krzksz @ptylek Hi can you guys take a look at this ?

@krzksz
Copy link
Contributor

krzksz commented Jun 19, 2020

@magento run all tests

@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jun 25, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 23, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 29, 2020

@magento run Functional Tests B2B

@woutk88
Copy link
Contributor

woutk88 commented Aug 2, 2020 •
edited
Loading

Seems like this code is actually taken/copied from the Luma theme.

It probably is an improvement to the theme but I'm not sure of the 'impact' on themes currently extending from Blank. Nevertheless, because you're moving code from Luma into Blank, you should be able to safely remove that code from Luma since that theme extends from Blank.

@mrtuvn mrtuvn force-pushed the add-collapsible-nav-in-customer-account branch from d6761ea to f1e9331 Compare August 3, 2020 08:15
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 3, 2020

@magento run all tests

@mrtuvn mrtuvn force-pushed the add-collapsible-nav-in-customer-account branch from f1e9331 to 0f599af Compare August 3, 2020 09:00
@mrtuvn mrtuvn requested a review from woutk88 August 3, 2020 09:05
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 3, 2020

@woutk88 thanks for your review

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 3, 2020

@magento run all tests

@mrtuvn mrtuvn force-pushed the add-collapsible-nav-in-customer-account branch from 0f599af to 18bf000 Compare September 16, 2020 13:49
@mrtuvn mrtuvn force-pushed the add-collapsible-nav-in-customer-account branch from 18bf000 to b351d50 Compare September 20, 2020 00:53
@ihor-sviziev ihor-sviziev self-assigned this Sep 29, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 29, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 29, 2020

@magento run Sample Data Tests EE, Integration Tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8285 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Sep 30, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 30, 2020
Closed
4 tasks
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Login to customer account page in mobile
  2. Navigation should show in top and collapsible on touch for visible links navigate to another page

Before: ✖️ collapsible nav block is missing

Mobile:

2020-09-30_10-06

After:

Mobile: ✔️ Navigation show on top and collapsible on touch

2020-09-30_09-57

Desktop:

Screenshot from 2020-09-30 10-18-15

Also, was checked on the Luma theme and everything works as expected.

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 30, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 30, 2020
@gabrieldagama
ENGCOM-8285: Add collapsible nav in customer account theme blank #28177
1b6e3e8
@magento-engcom-team magento-engcom-team merged commit 55a8ec7 into magento:2.4-develop Sep 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the add-collapsible-nav-in-customer-account branch October 24, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutk88 woutk88 woutk88 approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests improvement Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Add collapsible nav in customer account theme blank
7 participants
@mrtuvn @krzksz @woutk88 @ihor-sviziev @magento-engcom-team @engcom-Alfa @VladimirZaets