Skip to content

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 19, 2020
Merged

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2b45e6
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 5, 2020
c716884
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese Aug 6, 2020
9a2f265
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese Aug 10, 2020
8d9d0a5
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 10, 2020
512942e
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese Aug 11, 2020
7e34bc9
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 11, 2020
0f9189e
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 11, 2020
c4055cc
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese Aug 12, 2020
3b350fd
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 12, 2020
bf77de0
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese Aug 14, 2020
5f1d43a
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ define([
form = modalElement.find('#image-edit-details-form'),
imageId = this.imageModel().getSelected().id,
keywords = this.mediaGalleryEditDetails().selectedKeywords(),
imageDetails = this.mediaGalleryImageDetails();
imageDetails = this.mediaGalleryImageDetails(),
imageEditDetails = this.mediaGalleryEditDetails();

if (form.validation('isValid')) {
saveDetails(
Expand All @@ -98,6 +99,7 @@ define([
this.closeModal();
this.imageModel().reloadGrid();
imageDetails.removeCached(imageId);
imageEditDetails.removeCached(imageId, keywords);

if (imageDetails.isActive()) {
imageDetails.showImageDetailsById(imageId);
Expand Down
10 changes: 10 additions & 0 deletions app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,16 @@ define([
}

return true;
},

/**
* Remove cached image details in edit form
*
* @param {String} id
* @param {String} tags
*/
removeCached: function (id, tags) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simply remove cached image and rely on reloading from the backend to make sure frontend and backend are on the same page

this.images[id].tags = tags;
}
});
});