Skip to content

Revert "Add validation phone field on checkout page" #29682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Revert "Add validation phone field on checkout page" #29682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/code/Magento/Checkout/Block/Checkout/LayoutProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,6 @@ private function getBillingAddressComponent($paymentCode, $elements)
],
],
'telephone' => [
'validation' => [
'validate-phoneStrict' => 0,
],
'config' => [
'tooltip' => [
'description' => __('For delivery questions.'),
Expand Down
44 changes: 0 additions & 44 deletions app/code/Magento/Checkout/Test/Mftf/Test/StorefrontOnePageCheckoutPhoneValidationTest.xml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions app/code/Magento/Checkout/view/frontend/layout/checkout_index_index.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@
</item>
</item>
<item name="telephone" xsi:type="array">
<item name="validation" xsi:type="array">
<item name="validate-phoneStrict" xsi:type="number">0</item>
</item>
<item name="config" xsi:type="array">
<item name="tooltip" xsi:type="array">
<item name="description" xsi:type="string" translate="true">For delivery questions.</item>
Expand Down
8 changes: 4 additions & 4 deletions app/code/Magento/Customer/Test/Mftf/Data/AddressData.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<item>Bld D</item>
</array>
<data key="company">Magento</data>
<data key="telephone">123-456-7890</data>
<data key="telephone">1234568910</data>
<data key="fax">1234568910</data>
<data key="postcode">78729</data>
<data key="city">Austin</data>
Expand Down Expand Up @@ -172,7 +172,7 @@
<data key="city">London</data>
<data key="postcode">SE1 7RW</data>
<data key="country_id">GB</data>
<data key="telephone">444-444-4444</data>
<data key="telephone">444-44-444-44</data>
</entity>
<entity name="US_Address_Utah" type="address">
<data key="firstname">John</data>
Expand Down Expand Up @@ -227,7 +227,7 @@
<data key="firstname">John</data>
<data key="lastname">Doe</data>
<data key="company">Magento</data>
<data key="telephone">888-777-7890</data>
<data key="telephone">0123456789-02134567</data>
<array key="street">
<item>172, Westminster Bridge Rd</item>
<item>7700 xyz street</item>
Expand Down Expand Up @@ -305,7 +305,7 @@
<data key="firstname">Jane</data>
<data key="lastname">Miller</data>
<data key="company">Magento</data>
<data key="telephone">123-456-7899</data>
<data key="telephone">44 20 7123 1234</data>
<array key="street">
<item>1 London Bridge Street</item>
</array>
Expand Down