[MFTF] Removed redundant action group #29833

Usik2203 · 2020-08-31T19:09:23Z

This PR remove redundunt ActionGroup i see that name of the file is different than name action group.
We should use app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpenCmsBlockActionGroup.xml instead
app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockActionGroup.xml

Resolved issues:

resolves [Issue] [MFTF] Removed redundant action group #29839: [MFTF] Removed redundant action group

m2-assistant · 2020-08-31T19:09:25Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2020-08-31T19:09:58Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

sidolov · 2020-08-31T20:47:10Z

app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockActionGroup.xml

-->
-<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="AdminOpenCmsBlockActionGroup">


Unfortunately, we cannot remove action groups since it's backward incompatible. Use deprecated attribute instead.

Please, use <actionGroup name="GoToAttributeGridPageActionGroup" deprecated="reference to the new group">

sidolov · 2020-08-31T20:47:31Z

@magento create issue

lbajsarowicz

🔴 As @sidolov pointed - we need to mark the Action Group as deprecated.
Soon we'll have Magento 2.5 branch available, so you'll be able to remove it there.

Usik2203 · 2020-09-02T09:55:04Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

Usik2203 · 2020-09-04T18:04:42Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

sidolov · 2020-09-04T18:50:56Z

app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockActionGroup.xml

-->
-<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="AdminOpenCmsBlockActionGroup">


Please, use <actionGroup name="GoToAttributeGridPageActionGroup" deprecated="reference to the new group">

lbajsarowicz · 2020-09-07T22:17:55Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

magento-engcom-team · 2020-09-07T22:18:48Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8156 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-09-08T07:28:24Z

QA not applicable

…ctionGroup.xml Co-authored-by: Lukasz Bajsarowicz <[email protected]>

Usik2203 · 2020-09-08T08:36:10Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

engcom-Echo · 2020-09-08T09:22:19Z

Hi, @Usik2203. Please can you fix functional tests?

Usik2203 · 2020-09-08T09:28:43Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

engcom-Echo · 2020-09-08T10:08:28Z

@magento run Functional Tests CE

Usik2203 · 2020-09-09T08:38:53Z

Hi @sidolov @lbajsarowicz
So here's what I'm thinking

If I will remove file app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockActionGroup.xml and it will not be backward incompatible.

Because AdminOpenCmsBlockActionGroup is defined in app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpenCmsBlockActionGroup.xml and have similar name and functionality

And users who use AdminOpenCmsBlockActionGroup will continue to use it without problem

What do you think about it ?

lbajsarowicz · 2020-09-09T10:37:44Z

What you say is that we have 2 files that contain the same ActionGroup?
If that's the case - then of course you can remove 1 of these as it's not backwards-incompatible (still reference to the Action Group works).

Usik2203 · 2020-09-09T12:22:08Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

engcom-Echo · 2020-09-10T09:02:06Z

@magento run all tests

m2-assistant · 2020-09-12T18:36:56Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Removed redundant action group

c67c5f8

ghost added the Progress: pending review label Aug 31, 2020

magento-engcom-team added Component: Cms Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 31, 2020

Merge branch '2.4-develop' into v11-remove-redundunt-action-group

e2cc35c

Usik2203 changed the title ~~Removed redundant action group~~ [MFTF] Removed redundant action group Aug 31, 2020

lbajsarowicz self-assigned this Aug 31, 2020

lbajsarowicz added the Cleanup label Aug 31, 2020

sidolov requested changes Aug 31, 2020

View reviewed changes

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 31, 2020

m2-assistant bot mentioned this pull request Aug 31, 2020

[Issue] [MFTF] Removed redundant action group #29839

Closed

ghost assigned sidolov Aug 31, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 31, 2020

lbajsarowicz suggested changes Sep 1, 2020

View reviewed changes

Set action Group as deprecation

7f311a3

ghost assigned Usik2203 Sep 2, 2020

Merge branch '2.4-develop' into v11-remove-redundunt-action-group

c56157b

Usik2203 mentioned this pull request Sep 2, 2020

[MFTF] Added new ActionGroup for clicking AddToCart button #29820

Merged

1 task

Merge branch '2.4-develop' into v11-remove-redundunt-action-group

d32100e

sidolov requested changes Sep 4, 2020

View reviewed changes

use depricated tag

4c66066

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 7, 2020

engcom-Alfa self-assigned this Sep 8, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 8, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 8, 2020

Update app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockA…

ce46ca6

…ctionGroup.xml Co-authored-by: Lukasz Bajsarowicz <[email protected]>

engcom-Echo self-assigned this Sep 8, 2020

minor fix

9b16538

revert name

d2c7d4c

remove redundunt file

babb4ef

engcom-Echo requested a review from sidolov September 10, 2020 11:03

ghost added Progress: accept and removed Progress: extended testing labels Sep 11, 2020

sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 11, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 12, 2020

ENGCOM-8156: [MFTF] Removed redundant action group #29833

29cc296

magento-engcom-team merged commit ee94e1b into magento:2.4-develop Sep 12, 2020

[MFTF] Removed redundant action group #29833

[MFTF] Removed redundant action group #29833

Uh oh!

Conversation

Usik2203 commented Aug 31, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolved issues:

Uh oh!

m2-assistant bot commented Aug 31, 2020

Uh oh!

Usik2203 commented Aug 31, 2020

Uh oh!

sidolov Aug 31, 2020

Choose a reason for hiding this comment

Uh oh!

Usik2203 Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Sep 4, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov commented Aug 31, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Usik2203 commented Sep 2, 2020

Uh oh!

Usik2203 commented Sep 4, 2020

Uh oh!

sidolov Sep 4, 2020

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Sep 7, 2020

Uh oh!

magento-engcom-team commented Sep 7, 2020

Uh oh!

engcom-Alfa commented Sep 8, 2020

Uh oh!

Usik2203 commented Sep 8, 2020

Uh oh!

engcom-Echo commented Sep 8, 2020

Uh oh!

Usik2203 commented Sep 8, 2020

Uh oh!

engcom-Echo commented Sep 8, 2020

Uh oh!

Usik2203 commented Sep 9, 2020

Uh oh!

lbajsarowicz commented Sep 9, 2020

Uh oh!

Usik2203 commented Sep 9, 2020

Uh oh!

engcom-Echo commented Sep 10, 2020

Uh oh!

m2-assistant bot commented Sep 12, 2020

Uh oh!

Uh oh!

Usik2203 commented Aug 31, 2020 •

edited by m2-assistant bot

Loading