Skip to content

[MFTF] Removed redundant action group #29833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 12, 2020
Merged

[MFTF] Removed redundant action group #29833

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c67c5f8
Removed redundant action group
Usik2203 Aug 24, 2020
e2cc35c
Merge branch '2.4-develop' into v11-remove-redundunt-action-group
Usik2203 Aug 31, 2020
7f311a3
Set action Group as deprecation
Usik2203 Sep 2, 2020
c56157b
Merge branch '2.4-develop' into v11-remove-redundunt-action-group
Usik2203 Sep 2, 2020
d32100e
Merge branch '2.4-develop' into v11-remove-redundunt-action-group
Usik2203 Sep 4, 2020
4c66066
use depricated tag
Usik2203 Sep 6, 2020
3095bbe
add clear description
Usik2203 Sep 7, 2020
ce46ca6
Update app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockA…
Usik2203 Sep 8, 2020
9b16538
minor fix
Usik2203 Sep 8, 2020
d2c7d4c
revert name
Usik2203 Sep 8, 2020
babb4ef
remove redundunt file
Usik2203 Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpenCmsPageActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminOpenCmsPageActionGroup">
<annotations>
<description>Open CMS edit page.</description>
</annotations>
<arguments>
<argument name="page_id" type="string"/>
</arguments>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpentCmsBlockActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminOpenCmsBlockActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we cannot remove action groups since it's backward incompatible. Use deprecated attribute instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use <actionGroup name="GoToAttributeGridPageActionGroup" deprecated="reference to the new group">

<actionGroup name="AdminOpenCmsBlockActionGroup" deprecated="Use app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminOpenCmsBlockActionGroup.xml instead.">
<arguments>
<argument name="block_id" type="string"/>
</arguments>
Expand Down