Grid search selectall issue

[engcom-Hotel]

Description (*)

Fix for selecting all on the grid during the search by keyword and select all on-page toggle after unchecked records.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<24348>
2. Fixes magento/magento2#<24400>

Manual testing scenarios (*)

1. UI Component grid indicates a wrong number of selections when removing keyword search #24348
2. Issues Found on Grid Multi-Select Column #24400

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Hotel]

@magento run all tests

[gabrieldagama]

Hi @engcom-Hotel, thanks for your pull request, it looks great, please have a look on my comments below:

[engcom-Alfa]

Hi @engcom-Hotel .

During testing, we faced the issue.

Manual testing scenario:

1. Select all records on the current page by clicking the header checkbox;
2. Go to the second page;

Actual Result:

✖️ you will see that the header checkbox is selected on all remaining pages

@engcom-Hotel Could you take a look?

Thanks!

Pull Request state was updated. Re-review required.

[gabrieldagama]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8175 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Case 1.

1. Open any grid with more than 1 page (Customers for example);
2. In the 'Search by keyword' box, enter '[email protected]' and search;
3. In the first column, choose the 'Select All' option
4. Notice that one record is selected:

5. Remove the '[email protected]' keyword search by pressing the 'x' icon to the right of it.

Before: ❌ It is shown that one сcustomer is selected but in fact, all entries in the grid are selected

After: ✔️ Now when we clear the search filter all the checkbox marks in the grid are also removed

Note: applied the same behavior as filters have.

Case 2

1. Click on Header Checkbox to select all records on the current page;
2. Now unselect some record, on click particular row;
3. Again click on Header Checkbox;

After: ✔️ all records are unselected and the header checkbox is unselected.

[engcom-Alfa]

The new ticket #29996 has been created for the issue described in the comment as it was not caused by changes in this PR.

[engcom-Charlie]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[gabrieldagama]

@magento run all tests

[m2-assistant]

Hi @engcom-Hotel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.