Skip to content

Add INT types in some WHERE IN (?) expressions #31098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2020
Merged

Add INT types in some WHERE IN (?) expressions #31098

merged 3 commits into from
Dec 21, 2020

Conversation

ilnytskyi
Copy link
Contributor

@ilnytskyi ilnytskyi commented Nov 30, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Numeric values in the WHERE IN expressions should be cast as number, not as string.
It improves queries time on same MariaDB versions

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add INT types in some WHERE IN (?) expressions #31135: Add INT types in some WHERE IN (?) expressions

@m2-assistant
Copy link

m2-assistant bot commented Nov 30, 2020

Hi @ilnytskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ilnytskyi
Copy link
Contributor Author

@magento run all tests

@mrtuvn
Copy link
Contributor

mrtuvn commented Nov 30, 2020 •
edited
Loading

just curious Is this missing part happen in other modules ?

@ihor-sviziev ihor-sviziev self-assigned this Nov 30, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 30, 2020
ihor-sviziev
ihor-sviziev requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilnytskyi,
Could you fix failing unit tests?

@ilnytskyi
Copy link
Contributor Author

@ihor-sviziev yes

@ilnytskyi
Copy link
Contributor Author

@magento run Unit Tests

1 similar comment
@ilnytskyi
Copy link
Contributor Author

@magento run Unit Tests

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 2, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 2, 2020

@magento create issue

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 3, 2020 •
edited
Loading

Ok. Unit tests not failing anymore. Let's re-run the tests and approve if they're passing
@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Unit Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

ihor-sviziev
ihor-sviziev approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8510 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

QA not applicable. Moving the PR to the Extended Testing column

@engcom-Charlie engcom-Charlie removed their assignment Dec 17, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Dec 17, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020
@sidolov
ENGCOM-8510: Add INT types in some WHERE IN (?) expressions #31098
b2b9fbb
@magento-engcom-team magento-engcom-team merged commit 96ac57c into magento:2.4-develop Dec 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

Hi @ilnytskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: AdvancedPricingImportExport Component: Bundle Component: Catalog Component: CatalogGraphQl Component: CatalogInventory Component: CatalogRule Component: ConfigurableProduct Component: GroupedProduct Component: ProductVideo Component: Reports Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Add INT types in some WHERE IN (?) expressions
8 participants
@ilnytskyi @mrtuvn @sidolov @ihor-sviziev @magento-engcom-team @engcom-Bravo @engcom-Charlie @engcom-Foxtrot