TST: add test demonstrating the ndebug issue #379
Conversation
| def test_ndebug(package_scipy_like, tmp_path, args): | ||
| with mesonpy._project({'setup-args': args}) as project: | ||
| command = subprocess.run( | ||
| ['ninja', '-C', os.fspath(project._build_dir), '-t', 'commands', '../../mypkg/extmod.c^'], |
There was a problem hiding this comment.
The ^ asks ninja to report the build command for the target having the file preceding the ^ as part of its inputs. See the second paragraph here https://ninja-build.org/manual.html#_running_ninja
There was a problem hiding this comment.
Ah interesting, didn't know that.
|
I didn't meant this to be merged but only as a reproducer of the issue I saw. It would need some adjustment if we want to merge it. |
|
This can be closed now that gh-383 is merged I assume? |
|
The purpose of #383 is also to fix this, thus this can be closed. However, there isn't a test that makes sure the |
Good point. That's a fairly low-probability thing, so I'll close this and open a follow-up issue to add a test (after the next release). |
The meson-python
-Db_ndebug=if-releasedefault option does not have effect unless the project is also configured with-Dbuildtype=releaseordefault_options: ['buildtype=release']is specified inproject(). I believe this was not the desired effect.