Update user baselines #42451
Update user baselines #42451
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
There was a problem hiding this comment.
Looks like there's still work to do for xterm.js, vscode and azure-sdk. office-ui-fabric still looks super broken, but now in a different way. I guess it's fine to merge once #42431 is in, but it's still the case that the docker tests are half-useful at best.
| error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'. | ||
| The file is in the program because: | ||
| Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions | ||
| error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'. |
There was a problem hiding this comment.
these errors seem worse than before
There was a problem hiding this comment.
I'm not certain we can know what broke this. None of the projects fixed by #42431 have been building or contributing updated logs for some time now, so there's no way to know what caused these breaks. All of these breaks are based on what is in master now.
There was a problem hiding this comment.
The only thing I changed for xterm was the NodeJS version (since xterm started requiring features not present in NodeJS 8). This seems like a problem with their build, not our test (and these user tests often seem to run afoul of that).
| @@ -1,11 +1,24 @@ | |||
| Exit Code: 0 | |||
| Exit Code: 1 | |||
There was a problem hiding this comment.
this is worse than before, right? Is this due to our test harness changing or vscode changing?
There was a problem hiding this comment.
We haven't been building vscode for awhile, so there's now way to know. This is what vscode reports for master now (after getting the build to actually run in #42431).
There was a problem hiding this comment.
This is probably something we can ignore? The error reported is that monaco.d.ts changed (from here), which is likely due to Anders's type alias naming PR. The error will likely go away once vscode is building using 4.2 and generates a stable copy of monaco.d.ts.
| @@ -63,7 +64,7 @@ Executing a maximum of ?simultaneous processes... | |||
| "@azure/event-processor-host" is blocked by "@azure/eslint-plugin-azure-sdk". | |||
| "testhub" is blocked by "@azure/eslint-plugin-azure-sdk". | |||
| "@azure/logger" is blocked by "@azure/eslint-plugin-azure-sdk". | |||
| ==[ BLOCKED: 57 projects ]===================================================== | |||
| ==[ BLOCKED: 58 projects ]===================================================== | |||
There was a problem hiding this comment.
looks like azure-sdk is still blocked by not installing (or a bad install?) @typescript-eslint/scope-manager
There was a problem hiding this comment.
Is this our issue or an issue in azure-sdk? I didn't do anything for azure-sdk in #42431, so as far as I can tell this is just the latest build output from master.
|
This is purely to get us caught up now that we're actually running projects like The important thing is re-establishing our baseline for anything else we want to test for 4.2, since now that #42431 has merged everyone running the user tests will be seeing these due to an out-of-date baseline. |
|
I need to merge this soon so I can move forward with running the user tests against several community PRs. Given this is a baseline update based on what's already in master (and not a functionality update), unless someone has a pressing concern, I'll probably merge this in the next 30 minutes. |
Accepts the new user baselines from #42431