Skip to content

Update user baselines #42451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Update user baselines #42451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f13489
Update user baselines +cc @sandersn
typescript-bot Jan 21, 2021
3313b37
Update user baselines
typescript-bot Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/baselines/reference/docker/azure-sdk.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ Exit Code: 1
Standard output:

Rush Multi-Project Build Tool 5.X.X - https://rushjs.io
Node.js version is 15.5.1 (unstable)
Node.js version is 15.6.0 (unstable)
Starting "rush rebuild"
Executing a maximum of ?simultaneous processes...
==[ @azure/eslint-plugin-azure-sdk ]==============================[ 1 of 58 ]==
==[ @azure/eslint-plugin-azure-sdk ]==============================[ 1 of 59 ]==
"@azure/abort-controller" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/communication-administration" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/communication-chat" is blocked by "@azure/eslint-plugin-azure-sdk".
Expand Down Expand Up @@ -54,6 +54,7 @@ Executing a maximum of ?simultaneous processes...
"@azure/storage-internal-avro" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/test-utils-multi-version" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/core-https" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/core-crypto" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/core-asynciterator-polyfill" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/core-paging" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/core-tracing" is blocked by "@azure/eslint-plugin-azure-sdk".
Expand All @@ -63,7 +64,7 @@ Executing a maximum of ?simultaneous processes...
"@azure/event-processor-host" is blocked by "@azure/eslint-plugin-azure-sdk".
"testhub" is blocked by "@azure/eslint-plugin-azure-sdk".
"@azure/logger" is blocked by "@azure/eslint-plugin-azure-sdk".
==[ BLOCKED: 57 projects ]=====================================================
==[ BLOCKED: 58 projects ]=====================================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like azure-sdk is still blocked by not installing (or a bad install?) @typescript-eslint/scope-manager

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this our issue or an issue in azure-sdk? I didn't do anything for azure-sdk in #42431, so as far as I can tell this is just the latest build output from master.

These projects were blocked by dependencies that failed:
@azure/abort-controller
@azure/ai-anomaly-detector
Expand All @@ -80,6 +81,7 @@ These projects were blocked by dependencies that failed:
@azure/core-asynciterator-polyfill
@azure/core-auth
@azure/core-client
@azure/core-crypto
@azure/core-http
@azure/core-https
@azure/core-lro
Expand Down Expand Up @@ -141,8 +143,7 @@ rush rebuild (? seconds)


Standard error:
Your version of Node.js (X.X.X) has not been tested with this release of Rush. Please consider installing a newer version of the "@microsoft/rush" package, or downgrading Node.js.
Your version of Node.js (X.X.X) is an odd-numbered release. These releases frequently have bugs. Please consider installing a Long Term Support (LTS) version instead.
Your version of Node.js (X.X.X) has not been tested with this release of the Rush engine. Please consider upgrading the "rushVersion" setting in rush.json, or downgrading Node.js.
Returned error code: 2
"@azure/eslint-plugin-azure-sdk" failed to build.
Projects failed to build.
1,462 changes: 1,187 additions & 275 deletions tests/baselines/reference/docker/office-ui-fabric.log
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions tests/baselines/reference/docker/prettier.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Exit Code: 0
Standard output:
yarn run vX.X.X
$ node --max-old-space-size=3072 ./scripts/build/build.js
Building packages
index.js....................... DONE
doc.js......................... DONE
standalone.js.................. DONE
bin-prettier.js................ DONE
third-party.js................. DONE
parser-babel.js................ DONE
parser-flow.js................. DONE
parser-typescript.js........... DONE
parser-espree.js............... DONE
parser-meriyah.js.............. DONE
parser-angular.js.............. DONE
parser-postcss.js.............. DONE
esm/parser-postcss.mjs......... DONE
parser-graphql.js.............. DONE
parser-markdown.js............. DONE
parser-glimmer.js.............. DONE
parser-html.js................. DONE
parser-yaml.js................. DONE
Done in ?s.



Standard error:
21 changes: 17 additions & 4 deletions tests/baselines/reference/docker/vscode.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
Exit Code: 0
Exit Code: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is worse than before, right? Is this due to our test harness changing or vscode changing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't been building vscode for awhile, so there's now way to know. This is what vscode reports for master now (after getting the build to actually run in #42431).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably something we can ignore? The error reported is that monaco.d.ts changed (from here), which is likely due to Anders's type alias naming PR. The error will likely go away once vscode is building using 4.2 and generates a stable copy of monaco.d.ts.

Standard output:
yarn run vX.X.X
$ gulp compile --max_old_space_size=4095
[XX:XX:XX] Node flags detected: --max_old_space_size=4095
$ node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js compile
[XX:XX:XX] Using gulpfile /vscode/gulpfile.js
Done in ?s.
[XX:XX:XX] [monaco.d.ts] monaco.d.ts is changed - total time took ?s
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.



Standard error:
[XX:XX:XX] 'compile' errored after ?s
[XX:XX:XX] Error: monaco.d.ts is no longer up to date. Please run gulp watch and commit the new file.
at formatError (/vscode/node_modules/gulp-cli/lib/versioned/^4.0.0/format-error.js:20:10)
at Gulp.<anonymous> (/vscode/node_modules/gulp-cli/lib/versioned/^4.0.0/log/events.js:31:15)
at Gulp.emit (events.js:203:15)
at Gulp.EventEmitter.emit (domain.js:448:20)
at Object.error (/vscode/node_modules/undertaker/lib/helpers/createExtensions.js:61:10)
at handler (/vscode/node_modules/now-and-later/lib/map.js:46:14)
at f (/vscode/node_modules/once/once.js:25:25)
at f (/vscode/node_modules/once/once.js:25:25)
at tryCatch (/vscode/node_modules/async-done/index.js:24:15)
at done (/vscode/node_modules/async-done/index.js:40:12)
error Command failed with exit code 1.
16 changes: 8 additions & 8 deletions tests/baselines/reference/docker/vue-next.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ created packages/compiler-ssr/dist/compiler-ssr.cjs.js in ?s
Warning: dist/packages/compiler-sfc/src/compileScript.d.ts:27:36 - (tsdoc-escape-greater-than) The ">" character should be escaped using a backslash to avoid confusion with an HTML tag
Warning: dist/packages/compiler-sfc/src/compileScript.d.ts:27:23 - (tsdoc-html-tag-missing-equals) The HTML element has an invalid attribute: Expecting "=" after HTML attribute name
Warning: dist/packages/compiler-sfc/src/compileStyle.d.ts:18:8 - (tsdoc-missing-deprecation-message) The @deprecated block must include a deprecation message, e.g. describing the recommended alternative
/vue-next/packages/reactivity/src/index.ts → packages/reactivity/dist/reactivity.esm-bundler.js...
/vue-next/packages/runtime-core/src/index.ts → packages/runtime-core/dist/runtime-core.esm-bundler.js...
/vue-next/packages/reactivity/src/index.ts → packages/reactivity/dist/reactivity.esm-bundler.js...
[!] (plugin rpt2) Error: /vue-next/packages/reactivity/src/baseHandlers.ts(192,3): semantic error TS2322: Type '(target: object) => (string | number | symbol)[]' is not assignable to type '(target: object) => ArrayLike<string | symbol>'.
Type '(string | number | symbol)[]' is not assignable to type 'ArrayLike<string | symbol>'.
Index signatures are incompatible.
Expand All @@ -104,9 +104,9 @@ Error: /vue-next/packages/reactivity/src/baseHandlers.ts(192,3): semantic error
Type 'string | number | symbol' is not assignable to type 'string | symbol'.
Type 'number' is not assignable to type 'string | symbol'.
at error (/vue-next/node_modules/rollup/dist/shared/rollup.js:4533:30)
at throwPluginError (/vue-next/node_modules/rollup/dist/shared/rollup.js:18092:12)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:18699:24)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:18261:38)
at throwPluginError (/vue-next/node_modules/rollup/dist/shared/rollup.js:18144:12)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:18751:24)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:18313:38)
at RollupContext.error (/vue-next/node_modules/rollup-plugin-typescript2/src/rollupcontext.ts:37:18)
at /vue-next/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:41:11
at arrayEach (/vue-next/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:516:11)
Expand All @@ -116,13 +116,13 @@ Error: /vue-next/packages/reactivity/src/baseHandlers.ts(192,3): semantic error
/vue-next/node_modules/brotli/build/encode.js:3
1<process.argv.length?process.argv[1].replace(/\\/g,"/"):"unknown-program");b.arguments=process.argv.slice(2);"undefined"!==typeof module&&(module.exports=b);process.on("uncaughtException",function(a){if(!(a instanceof y))throw a;});b.inspect=function(){return"[Emscripten Module object]"}}else if(x)b.print||(b.print=print),"undefined"!=typeof printErr&&(b.printErr=printErr),b.read="undefined"!=typeof read?read:function(){throw"no read() available (jsc?)";},b.readBinary=function(a){if("function"===
^
Error: Command failed with exit code 1: rollup -c --environment COMMIT:e79feb0,NODE_ENV:production,TARGET:reactivity,TYPES:true
Error: Command failed with exit code 1: rollup -c --environment COMMIT:c2f4664,NODE_ENV:production,TARGET:reactivity,TYPES:true
at makeError (/vue-next/node_modules/execa/lib/error.js:59:11)
at handlePromise (/vue-next/node_modules/execa/index.js:114:26)
at processTicksAndRejections (node:internal/process/task_queues:93:5)
at processTicksAndRejections (node:internal/process/task_queues:94:5)
at async build (/vue-next/scripts/build.js:91:3) {
shortMessage: 'Command failed with exit code 1: rollup -c --environment COMMIT:e79feb0,NODE_ENV:production,TARGET:reactivity,TYPES:true',
command: 'rollup -c --environment COMMIT:e79feb0,NODE_ENV:production,TARGET:reactivity,TYPES:true',
shortMessage: 'Command failed with exit code 1: rollup -c --environment COMMIT:c2f4664,NODE_ENV:production,TARGET:reactivity,TYPES:true',
command: 'rollup -c --environment COMMIT:c2f4664,NODE_ENV:production,TARGET:reactivity,TYPES:true',
exitCode: 1,
signal: undefined,
signalDescription: undefined,
Expand Down
23 changes: 23 additions & 0 deletions tests/baselines/reference/docker/xterm.js.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,37 @@ Standard output:

> [email protected] build /xtermjs
> tsc -b ./tsconfig.all.json
src/browser/Terminal2.test.ts(80,11): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these errors seem worse than before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain we can know what broke this. None of the projects fixed by #42431 have been building or contributing updated logs for some time now, so there's no way to know what caused these breaks. All of these breaks are based on what is in master now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I changed for xterm was the NodeJS version (since xterm started requiring features not present in NodeJS 8). This seems like a problem with their build, not our test (and these user tests often seem to run afoul of that).

The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
addons/xterm-addon-ligatures/src/font.ts(6,29): error TS2307: Cannot find module 'font-finder' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/font.ts(7,32): error TS2307: Cannot find module 'font-ligatures' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.ts(7,22): error TS2307: Cannot find module 'font-ligatures' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.ts(75,14): error TS2347: Untyped function calls may not accept type arguments.
addons/xterm-addon-ligatures/src/index.ts(76,9): error TS7006: Parameter 'range' implicitly has an 'any' type.
addons/xterm-addon-ligatures/src/index.test.ts(6,23): error TS2307: Cannot find module 'path' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.test.ts(7,24): error TS2307: Cannot find module 'sinon' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.test.ts(9,29): error TS2307: Cannot find module 'font-finder' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.test.ts(10,32): error TS2307: Cannot find module 'font-ligatures' or its corresponding type declarations.
addons/xterm-addon-ligatures/src/index.test.ts(26,25): error TS2304: Cannot find name '__dirname'.
addons/xterm-addon-ligatures/src/index.test.ts(33,25): error TS2304: Cannot find name '__dirname'.
addons/xterm-addon-ligatures/src/index.test.ts(40,25): error TS2304: Cannot find name '__dirname'.
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions
error TS2688: Cannot find type definition file for '../../../out-test/api/TestUtils'.
The file is in the program because:
Entry point of type library '../../../out-test/api/TestUtils' specified in compilerOptions



Expand Down
1 change: 0 additions & 1 deletion tests/baselines/reference/user/TypeScript-Node-Starter.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Standard output:
node_modules/connect-mongo/src/types.d.ts(113,66): error TS2694: Namespace 'Express' has no exported member 'SessionData'.
node_modules/connect-mongo/src/types.d.ts(114,45): error TS2694: Namespace 'Express' has no exported member 'SessionData'.
node_modules/connect-mongo/src/types.d.ts(118,47): error TS2694: Namespace 'Express' has no exported member 'SessionData'.
src/app.ts(31,10): error TS2540: Cannot assign to 'Promise' because it is a read-only property.
src/app.ts(72,21): error TS2339: Property 'returnTo' does not exist on type 'Session & Partial<SessionData>'.
src/app.ts(75,21): error TS2339: Property 'returnTo' does not exist on type 'Session & Partial<SessionData>'.
src/app.ts(116,30): error TS2339: Property 'returnTo' does not exist on type 'Session & Partial<SessionData>'.
Expand Down