New package Flow #324

eleanorjboyd · 2025-04-22T20:18:09Z

Implement the flow to allow for "New Package" support

eleanorjboyd · 2025-04-22T22:06:32Z

src/features/creators/creationHelpers.ts

+            if (envManager.quickCreateConfig) {
+                options.quickCreate = true;
+            }
+            const pyEnv = await envManager.create(destUri, options);


getting an error when creating this but see the venv folder correctly setup inside my project. I think it tries to run Running: uv pip install --python /Users/eleanorboyd/testingFiles/notebook-for-copilot/yay_project/.venv/bin/python right after creating the venv and that is causing issues?

2025-04-22 15:02:57.432 [info] error: / does not appear to be a Python project, as neither `pyproject.toml` nor `setup.py` are present in the directory 2025-04-22 15:02:57.433 [error] Error managing packages Failed to run uv pip install --python /Users/eleanorboyd/testingFiles/notebook-for-copilot/yay_project/.venv/bin/python -r /Users/

There is no package being passed in for this to install, and that might be causing this.

ok currently investigating. What seems to happen is when calling quickCreateVenv, it calls const project = api.getPythonProject(venvRoot); . On the new project folder. This then ends up with the getter for python project which gets nothing for let pythonProject = this._projects.get(uri.toString()); and falls back to pythonProject = this.findProjectByUri(uri);. Somewhere I must not be setting the project for the given URI and so it attemps to find it during quick create and fails. This causes quick create to get all of the workspace's package installs (which are like all -r dev_requirements.txt) which it tries to install all at once and errors.

so the problem then boils down to, how do I make it so the venv gets created after the project gets registered or remove the requirement for registration as part of the quickEnv process? Since the function for create is called in envCommands.ts with export async function addPythonProject. This calls create and only after the create function finishes the project is pushed to the known projects. But as above, when I create the venv it tries to find the project which is not yet registered. Not sure the best design idea- curious your thoughts @karthiknadig

hm I am no longer seeing this error anymore and the PR to fix this is not merged with this- need to do more investigation as it seems this is no longer an issue (edit: nvm no error message is being thrown but too many requirements are being installed)

src/features/creators/creationHelpers.ts

src/features/creators/newPackageProject.ts

src/features/creators/templates/newPackageTemplate/README.md

src/features/creators/creationHelpers.ts

cwebster-99 · 2025-04-22T22:44:31Z

src/features/creators/newPackageProject.ts

+        }
+        const workspaceFolders = workspace.workspaceFolders;
+        if (!workspaceFolders || workspaceFolders.length === 0) {
+            window.showErrorMessage('No workspace folder is open.');


Are we able to open a workspace folder for them if it is empty using the logic Bhavya does with Create New?

Bhayva should supply a path where the new project should be created- is the concern if that path doesn't exist?

cwebster-99 · 2025-04-22T22:46:25Z

src/features/creators/templates/newPackageTemplate/.github/copilot-instructions.md

@@ -0,0 +1,8 @@
+# Copilot Instructions for <package_name>


See https://github.com/microsoft/vscode-python-templates/pull/4/files#diff-8263202d70318618891dd1a86fb62ccab9567201cc456e0085703a8c400b95f6 for additional items we can add to the instructions file

my question here is if I should add all these general rules or if that wont feel applicable to the action the user is taking of adding the project? cc @karthiknadig

src/features/creators/templates/newPackageTemplate/README.md

src/features/creators/templates/newPackageTemplate/.gitignore

src/features/creators/templates/newPackageTemplate/.vscode/launch.json

src/features/creators/templates/newPackageTemplate/README.md

src/features/creators/templates/newPackageTemplate/package_name/__main__.py

src/features/creators/creationHelpers.ts

eleanorjboyd · 2025-04-23T17:53:57Z

src/features/creators/templates/newPackageTemplate/.github/copilot-instructions.md

@@ -0,0 +1,10 @@
+# Copilot Instructions for package_name


@karthiknadig:

I have it right now that the template as a folder called <my_package>-folder which then has a folder <my_package>. Did this so I had somewhere to store the pyproject.toml and dev-requirements.txt. This does make it more complicated to do an editable install of the package at the root, not sure if this is worth the concern? I also worry people will delete / more that folder with higher frequency which then makes these instructions out of date

…package manager (microsoft#314)

Standardize the display names of various shell providers to use lowercase for consistency. Fixes microsoft#230

- renamed `addPythonProject` in src/features/envCommands.ts to `addPythonProjectCommand` (as it is only a command entry point) - moved responsibility so ProjectCreators are responsible for adding their created projects to the ProjectManager list - updated `addPythonProjectCommand` so it calls the selected ProjectCreator create method OR (if the resource param already a ProjectItem) just add it to the ProjectManager list