CDRIVER-5939 reintroduce VS 2015 task coverage #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Apr 11, 2025
kevinAlbs
approved these changes
Apr 11, 2025
eramongodb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CDRIVER-5939 following resolution of DEVPROD-16074. The providing distro is now
windows-vsCurrentrather than the initially proposedwindows64-vsMultidistro.Updated
compile-std.shto take advantage of CMake 3.30's CMAKE_<LANG>_STANDARD_LATEST variable to sanity-check that the requested C standard version is supported by the requested compiler (according to CMake). This exposed VS 2015 does not support C17:Additionally added a C compiler flag check to ensure the
/std:clatestflag is actually supported by the compilers rather than an easily-missed warning during the build step:This revealed none of the current MSVC installations on Evergreen support the
/std:clatestflag. This was verified via spawn host (however, they do support the/std:c++latestflag). It is unknown at the moment why the/std:clatestflag is missing or how to enable it (if possible). The tasks are therefore removed for now.Note
C11 and C17 tasks for VS 2017 and newer are currently failing with the proposed changes due to DEVPROD-16743. The distro is currently missing a required Windows 10 SDK version which patches C11 and C17 compatibility in system headers.