-
Notifications
You must be signed in to change notification settings - Fork 546
CXX-3253 reintroduce VS 2015 task coverage #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Converting to draft due to discovery of overlooked EVG configuration errors. Will fix and re-request reviews when ready. |
Identified While addressing this bug, took the opportunity to extend compiler coverage to better match that of the C Driver's std-matrix tasks, including coverage with Both of these updates revealed several issues which are addressed by this PR, as described below. Identified a few more references to C Driver hedged reads API in test code that were missed in #1351. Applied suppressions accordingly. The false-positive
To avoid this issue for good, changed all instances of the problematic Extending compiler coverage to GCC 4.8 (on rhel76) revealed the following compilation error:
This required adding the Following #1329, there should have been no more alignment-related issues in the C++ Driver. However, when removing an overlooked
Further investigation revealed a common pattern for all instances of this warning: the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compile matrix improvements (easier visibility to which compiler version is tested) are very much appreciated. LGTM
This reverts commit 2aff099.
Deferred attempts to resolve rhel76 task failure to #1384. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves CXX-3253. Followup to mongodb/mongo-c-driver#1991.