PYTHON-3885 Use tox in remaining Evergreen Tests #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested review from
sleepyStick and
NoahStapp
and removed request for
a team and
sleepyStick
NoahStapp
requested changes
Aug 9, 2023
|
|
||
| PYTHON=${PYTHON_BINARY:-} | ||
| if [ -z "$PYTHON" ]; then | ||
| if [ -z "$PYTHON_BINARY" ]; then |
There was a problem hiding this comment.
Do we need this file at all? What if we put the new contents directly into config.yml?
There was a problem hiding this comment.
We would still run these two files as entrypoints for local testing. I wanted to keep the logic out of config.yml where possible, and there are parts of this that we don't want to echo and parts that we do.
|
|
||
| PYTHON=${PYTHON_BINARY:-} | ||
| if [ -z "$PYTHON" ]; then | ||
| if [ -z "$PYTHON_BINARY" ]; then |
NoahStapp
approved these changes
Aug 9, 2023
|
Note: the OIDC failure is tracked in PYTHON-3909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.