-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-3885 Use tox in remaining Evergreen Tests #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
32712eb
PYTHON-3885 Use tox in remaining Evergreen Tests
blink1073 57fc0e3
fix calls and var names
blink1073 eebd4c5
fix call
blink1073 83fbb86
fix load balancer and ent auth
blink1073 7a8829d
fix aws and oidc auth
blink1073 4549973
cleanup
blink1073 ceeabe8
fixups for auth
blink1073 f7b574d
fix aws test
blink1073 2fdb6de
fix typo
blink1073 df76095
fix aws test
blink1073 2d67ec1
install virtualenv
blink1073 3a800c4
fix ent auth
blink1073 0d61365
undo change
blink1073 a0c0a09
install tox as user
blink1073 e34099c
cleanup
blink1073 14090b9
fix aws test
blink1073 5d0f9e3
fix aws test
blink1073 3a8069d
fix aws test
blink1073 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,41 +45,13 @@ if [ "$ASSERT_NO_URI_CREDS" = "true" ]; then | |
fi | ||
fi | ||
|
||
# show test output | ||
set -x | ||
|
||
# Workaround macOS python 3.9 incompatibility with system virtualenv. | ||
if [ "$(uname -s)" = "Darwin" ]; then | ||
VIRTUALENV="/Library/Frameworks/Python.framework/Versions/3.9/bin/python3 -m virtualenv" | ||
else | ||
VIRTUALENV=$(command -v virtualenv) | ||
fi | ||
|
||
authtest () { | ||
if [ "Windows_NT" = "$OS" ]; then | ||
PYTHON=$(cygpath -m $PYTHON) | ||
fi | ||
|
||
echo "Running MONGODB-OIDC authentication tests with $PYTHON" | ||
$PYTHON --version | ||
|
||
$VIRTUALENV -p $PYTHON --never-download venvoidc | ||
if [ "Windows_NT" = "$OS" ]; then | ||
. venvoidc/Scripts/activate | ||
else | ||
. venvoidc/bin/activate | ||
fi | ||
python -m pip install -U pip setuptools | ||
python -m pip install '.[aws]' | ||
python test/auth_aws/test_auth_oidc.py -v | ||
deactivate | ||
rm -rf venvoidc | ||
} | ||
|
||
PYTHON=${PYTHON_BINARY:-} | ||
if [ -z "$PYTHON" ]; then | ||
if [ -z "$PYTHON_BINARY" ]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for this file |
||
echo "Cannot test without specifying PYTHON_BINARY" | ||
exit 1 | ||
fi | ||
|
||
authtest | ||
export TEST_AUTH_OIDC=1 | ||
export AUTH_MECH="SCRAM-SHA-256" | ||
export AUTH="auth" | ||
export SET_XTRACE_ON=1 | ||
bash ./.evergreen/tox.sh -m test-eg |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file at all? What if we put the new contents directly into
config.yml
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would still run these two files as entrypoints for local testing. I wanted to keep the logic out of config.yml where possible, and there are parts of this that we don't want to echo and parts that we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!