Skip to content

chore: update code_health third parties action to their shas #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

chore: update code_health third parties action to their shas #3078

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
386c676
CLOUDP-236543: Disable e2e_local_deployments
andreaangiolillo Mar 11, 2024
0ee943d
Merge remote-tracking branch 'origin/master'
andreaangiolillo Mar 11, 2024
7425b6e
Merge remote-tracking branch 'origin/master'
andreaangiolillo Mar 13, 2024
11b7d6e
Merge remote-tracking branch 'origin/master'
andreaangiolillo Mar 14, 2024
06d9976
Merge remote-tracking branch 'origin/master'
andreaangiolillo Apr 22, 2024
c2984de
Merge remote-tracking branch 'origin/master'
andreaangiolillo Apr 23, 2024
806c4fd
Merge remote-tracking branch 'origin/master'
andreaangiolillo Apr 30, 2024
7af2546
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 1, 2024
c7f03c4
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 3, 2024
edafe8f
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 3, 2024
e8a6a4f
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 20, 2024
d18e168
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 22, 2024
cb573bb
Merge remote-tracking branch 'origin/master'
andreaangiolillo May 23, 2024
26108bf
Merge remote-tracking branch 'origin/master'
andreaangiolillo Jun 13, 2024
0f4c66b
Merge remote-tracking branch 'origin/master'
andreaangiolillo Jun 13, 2024
21ba6fc
Merge remote-tracking branch 'origin/master'
andreaangiolillo Jun 17, 2024
2d1a227
Merge remote-tracking branch 'origin/master'
andreaangiolillo Jun 20, 2024
e8cf8e9
Merge remote-tracking branch 'origin/master'
andreaangiolillo Jul 4, 2024
efc04b6
chore: add staticcheck
andreaangiolillo Jul 4, 2024
89b7561
Update code-health.yml
andreaangiolillo Jul 4, 2024
2e56d6b
Update code-health.yml
andreaangiolillo Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 35 additions & 34 deletions .github/workflows/code-health.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding was that actions supported by GH could remain on numbers and not shas, has this changed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using shas is actually really bad for security scanning tools as you may be able to see from #3063

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware of this, could you share where it was decided?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem if you don't find it. It makes sense that GH actions can be trusted

- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
cache: false # see https://github.com/golangci/golangci-lint-action/issues/807
- name: golangci-lint
uses: golangci/golangci-lint-action@v6.0.1
uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64
with:
version: v1.56.2
unit-tests:
Expand All @@ -35,21 +35,21 @@ jobs:
os: [ubuntu-latest, windows-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
if: ${{ matrix.os=='ubuntu-latest' }}
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- run: go install gotest.tools/gotestsum@latest
- run: make unit-test
- name: Test Summary
id: test_summary
uses: test-summary/action@v2.4
uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86
with:
paths: unit-tests.xml
if: always() && matrix.os == 'ubuntu-latest'
Expand All @@ -61,41 +61,41 @@ jobs:
INTEGRATION_TAGS: integration
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- run: go install gotest.tools/gotestsum@latest
- run: make fuzz-normalizer-test
libraryOwners:
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- name: Run check-library-owners
run: make check-library-owners
docs:
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- name: Generate docs
Expand All @@ -116,10 +116,10 @@ jobs:
actionlint:
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Download actionlint
id: get_actionlint
run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
Expand All @@ -132,13 +132,13 @@ jobs:
mocks:
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- name: Install go-mock
Expand All @@ -162,22 +162,22 @@ jobs:
name: shellcheck
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Run ShellCheck
uses: bewuethr/shellcheck-action@v2
uses: bewuethr/shellcheck-action@d01912909579c4b1a335828b8fca197fbb8e0aa4
tidy:
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- name: Run 'go mod tidy'
Expand All @@ -199,12 +199,12 @@ jobs:
name: licensecheck
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- run: make devtools
Expand All @@ -213,12 +213,13 @@ jobs:
name: checktemplates
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7
with:
config: ${{ vars.PERMISSIONS_CONFIG }}
- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7
with:
go-version-file: 'go.mod'
- run: make check-templates

Loading