Skip to content

test(NODE-4974): backport range index tests to 4x #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2023
Merged

test(NODE-4974): backport range index tests to 4x #3539

merged 3 commits into from
Jan 26, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jan 24, 2023 •
edited
Loading

Description

What is changing?

This PR backports tests for range index support to the 4x branch.

Changes should be easy to review, the commits were cherry picked straight from main.

Is there new documentation needed for these changes?

No.

@baileympearson baileympearson changed the base branch from main to 4.x January 24, 2023 18:17
@baileympearson baileympearson force-pushed the backport-range-index-support branch from 8be21f3 to 4c49b2e Compare January 24, 2023 21:41
@baileympearson baileympearson marked this pull request as ready for review January 24, 2023 21:50
@baileympearson baileympearson changed the title ci: pull in misc CI fixes for the 4x branch (#3536) test(NODE-4974): backport range index tests to 4x Jan 24, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 25, 2023
durran
durran requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the FLE tests to not run on LOWEST_LTS as Node 12 does not support importing 'fs/promises'

@baileympearson
Copy link
Contributor Author

@durran Instead of bumping the node version, I changed the import. We bumped to Node14 as a part of dropping support for Node12, which won't be a part of the 4.x branch.

@baileympearson baileympearson requested a review from durran January 25, 2023 15:35
@durran
Copy link
Member

durran commented Jan 25, 2023

@durran Instead of bumping the node version, I changed the import. We bumped to Node14 as a part of dropping support for Node12, which won't be a part of the 4.x branch.

Better solution. Thanks!

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 25, 2023
@durran durran merged commit ed6c957 into 4.x Jan 26, 2023
@durran durran deleted the backport-range-index-support branch January 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @durran @nbbeeken