Skip to content

CP/DP Split: Support configuring NodePorts #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Apr 29, 2025

Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values.

Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.

Testing: Verified that NodePorts are configurable and accessible.

Closes #3240

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sjberman sjberman requested a review from a team as a code owner April 29, 2025 21:03
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks helm-chart Relates to helm chart labels Apr 29, 2025
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (6337c97) to head (f62ed37).
Report is 266 commits behind head on change/control-data-plane-split.

Files with missing lines Patch % Lines
internal/mode/static/provisioner/handler.go 55.17% 5 Missing and 8 partials ⚠️
internal/mode/static/provisioner/provisioner.go 33.33% 2 Missing and 2 partials ⚠️
internal/mode/static/provisioner/store.go 93.44% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3343      +/-   ##
===================================================================
- Coverage                            89.74%   86.66%   -3.09%     
===================================================================
  Files                                  109      129      +20     
  Lines                                11150    14827    +3677     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12850    +2843     
- Misses                                1083     1829     +746     
- Partials                                60      148      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values.

Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.
@sjberman sjberman force-pushed the chore/nodeports-update branch from 9ea88eb to 7ee9489 Compare April 30, 2025 18:23
@sjberman sjberman force-pushed the chore/nodeports-update branch from ea9e947 to f62ed37 Compare April 30, 2025 19:07
@sjberman sjberman requested review from bjee19 and salonichf5 April 30, 2025 19:18
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjberman sjberman merged commit 52da4cf into change/control-data-plane-split Apr 30, 2025
43 of 44 checks passed
@sjberman sjberman deleted the chore/nodeports-update branch April 30, 2025 22:01
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants