-
Notifications
You must be signed in to change notification settings - Fork 114
CP/DP Split: Support configuring NodePorts #3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Split: Support configuring NodePorts #3343
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3343 +/- ##
===================================================================
- Coverage 89.74% 86.66% -3.09%
===================================================================
Files 109 129 +20
Lines 11150 14827 +3677
Branches 50 62 +12
===================================================================
+ Hits 10007 12850 +2843
- Misses 1083 1829 +746
- Partials 60 148 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values. Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.
9ea88eb
to
7ee9489
Compare
ea9e947
to
f62ed37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
52da4cf
into
change/control-data-plane-split
Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values.
Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.
Testing: Verified that NodePorts are configurable and accessible.
Closes #3240
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.