Skip to content

PIN: Set minimum numpy version to 1.9.0 #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Conversation

effigies
Copy link
Member

Fixes #2181.

Changes proposed in this pull request

  • Sets minimum numpy version to 1.9.0, to enable apply_along_axis to work as called
  • Fixes _numpy URL in docs

@effigies effigies requested a review from satra September 11, 2017 18:28
Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine with this change.

@codecov-io
Copy link

Codecov Report

Merging #2182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2182   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files        1168     1168           
  Lines       58408    58408           
  Branches     8400     8400           
=======================================
  Hits        42204    42204           
  Misses      14870    14870           
  Partials     1334     1334
Flag Coverage Δ
#smoketests 72.25% <100%> (ø) ⬆️
#unittests 69.91% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 84.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ead69d...6e7e5ca. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Sep 11, 2017

Codecov Report

Merging #2182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2182   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files        1168     1168           
  Lines       58408    58408           
  Branches     8400     8400           
=======================================
  Hits        42204    42204           
  Misses      14870    14870           
  Partials     1334     1334
Flag Coverage Δ
#smoketests 72.25% <100%> (ø) ⬆️
#unittests 69.91% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 84.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ead69d...6e7e5ca. Read the comment docs.

@effigies effigies merged commit 4a0bd3d into nipy:master Sep 12, 2017
@effigies effigies deleted the pin/min_numpy branch September 12, 2017 01:43
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants