RF: Separate mcparam -> affine translation from norm calculation in ArtifactDetect #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. is numpy 1.9 now our minimum? |
|
Since #2182. |
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
+ Coverage 72.27% 72.27% +<.01%
==========================================
Files 1174 1174
Lines 58738 58736 -2
Branches 8454 8454
==========================================
- Hits 42453 42452 -1
+ Misses 14924 14923 -1
Partials 1361 1361
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
+ Coverage 72.27% 72.27% +<.01%
==========================================
Files 1174 1174
Lines 58738 58736 -2
Branches 8454 8454
==========================================
- Hits 42453 42452 -1
+ Misses 14924 14923 -1
Partials 1361 1361
Continue to review full report at Codecov.
|
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 4, 2017
This was referenced Oct 4, 2017
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 5, 2017
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
algorithms.rapidart._calc_normuses an affine-based algorithm to calculate norms and displacements, translating from a list of motion parameters at each time point. This PR separates the two processes, creating a_calc_norm_affinefunction that performs the core functionality, which_calc_normpasses a list of affine matrices translated from the motion parameters.Changes proposed in this pull request
_calc_norm_affine_calc_normtranslates motion parameters, calls_calc_norm_affine_nanmean, since the minimum numpy (1.9) includesnp.nanmean