Skip to content

[FIX] 3dUndump interface #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017
Merged

[FIX] 3dUndump interface #2224

merged 1 commit into from
Oct 12, 2017

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Oct 12, 2017

Changes proposed in this pull request

  • fixes the interface for 3dUndump for some of its options
  • adds documentation from the afni command 3dUndump

@codecov-io
Copy link

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files        1180     1180           
  Lines       58885    58885           
  Branches     8474     8474           
=======================================
  Hits        42585    42585           
  Misses      14921    14921           
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (ø) ⬆️
#unittests 69.88% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/afni/tests/test_auto_Undump.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/afni/utils.py 83.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b7c81...f1a76cb. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files        1180     1180           
  Lines       58885    58885           
  Branches     8474     8474           
=======================================
  Hits        42585    42585           
  Misses      14921    14921           
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (ø) ⬆️
#unittests 69.88% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/afni/tests/test_auto_Undump.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/afni/utils.py 83.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b7c81...f1a76cb. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files        1180     1180           
  Lines       58885    58885           
  Branches     8474     8474           
=======================================
  Hits        42585    42585           
  Misses      14921    14921           
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (ø) ⬆️
#unittests 69.88% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/afni/tests/test_auto_Undump.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/afni/utils.py 83.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b7c81...f1a76cb. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files        1180     1180           
  Lines       58885    58885           
  Branches     8474     8474           
=======================================
  Hits        42585    42585           
  Misses      14921    14921           
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (ø) ⬆️
#unittests 69.88% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/afni/tests/test_auto_Undump.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/afni/utils.py 83.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b7c81...f1a76cb. Read the comment docs.

@effigies
Copy link
Member

Was -srad removed at a specific version and -orient added? You may want to have both, setting max_ver and min_ver arguments to these traits, rather than replacing one with the other.

@jdkent
Copy link
Contributor Author

jdkent commented Oct 12, 2017

@effigies: In the code, the option -srad was repeated twice and I think it they meant to include -orient, but it was an oversight. -srad is still a valid option

@effigies
Copy link
Member

Ah, I didn't read enough context. LGTM.

@effigies effigies merged commit 1a4e640 into nipy:master Oct 12, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
@satra satra modified the milestone: 0.14.0 Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants