Skip to content

ENH: Add segmentation output to FSL's epi_reg #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 30, 2018
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,10 @@
{
"name": "McDermottroe, Conor"
},
{
"affiliation": "Institute of Imaging & Computer Vision, RWTH Aachen University, Germany",
"name": "Weninger, Leon"
},
{
"affiliation": "MIT, HMS",
"name": "Ghosh, Satrajit",
Expand All @@ -587,4 +591,4 @@
],
"license": "Apache-2.0",
"upload_type": "software"
}
}
2 changes: 1 addition & 1 deletion nipype/interfaces/ants/registration.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class ANTSOutputSpec(TraitedSpec):


class ANTS(ANTSCommand):
"""ANTS wrapper for registration of images
"""ANTS wrapper for registration of images
(old, use Registration instead)

Examples
Expand Down
4 changes: 2 additions & 2 deletions nipype/interfaces/ants/tests/test_auto_AntsJointFusion.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ def test_AntsJointFusion_inputs():
hash_files=False,
),
out_label_post_prob_name_format=dict(
requires=['out_label_fusion', 'out_intensity_fusion_name_format'],
),
requires=['out_label_fusion',
'out_intensity_fusion_name_format'], ),
patch_metric=dict(argstr='-m %s', ),
patch_radius=dict(
argstr='-p %s',
Expand Down
4 changes: 4 additions & 0 deletions nipype/interfaces/fsl/epi.py
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,8 @@ class EpiRegOutputSpec(TraitedSpec):
structural space')
wmseg = File(
exists=True, desc='white matter segmentation used in flirt bbr')
seg = File(
exists=True, desc='white matter, gray matter, csf segmentation')
wmedge = File(exists=True, desc='white matter edges for visualization')


Expand Down Expand Up @@ -1013,6 +1015,8 @@ def _list_outputs(self):
os.getcwd(), self.inputs.out_base + '_fast_wmedge.nii.gz')
outputs['wmseg'] = os.path.join(
os.getcwd(), self.inputs.out_base + '_fast_wmseg.nii.gz')
outputs['seg'] = os.path.join(
os.getcwd(), self.inputs.out_base + '_fast_seg.nii.gz')

return outputs

Expand Down
1 change: 1 addition & 0 deletions nipype/interfaces/fsl/tests/test_auto_EpiReg.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def test_EpiReg_outputs():
fullwarp=dict(),
out_1vol=dict(),
out_file=dict(),
seg=dict(),
shiftmap=dict(),
wmedge=dict(),
wmseg=dict(),
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def add_traits(base, names, trait_type=None):


def _get_head_bucket(s3_resource, bucket_name):
""" Try to get the header info of a bucket, in order to
""" Try to get the header info of a bucket, in order to
check if it exists and its permissions
"""

Expand Down
1 change: 1 addition & 0 deletions nipype/testing/data/reg_average_cmd
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
reg_average /filesrv/weninger/code/nipype/nipype/testing/data/avg_out.nii.gz -avg im1.nii im2.nii im3.nii -omp 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file probably shouldn't be here.

2 changes: 1 addition & 1 deletion nipype/utils/filemanip.py
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ def loadpkl(infile, versioning=False):

return unpkl

# Unpickling problems
# Unpickling problems
except Exception as e:
if not versioning:
raise e
Expand Down
4 changes: 2 additions & 2 deletions nipype/utils/tests/test_filemanip.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ class PickledBreaker:
def __setstate__(self, d):
raise Exception()


def test_versioned_pklization(tmpdir):
tmpdir.chdir()

Expand All @@ -560,7 +560,7 @@ def test_versioned_pklization(tmpdir):

loadpkl('./pickled.pkz', versioning=True)


def test_unversioned_pklization(tmpdir):
tmpdir.chdir()

Expand Down