ENH: Support tckgen -select in MRtrix3 v3+ #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
- Coverage 67.46% 67.44% -0.02%
==========================================
Files 341 341
Lines 43392 43393 +1
Branches 5383 5383
==========================================
- Hits 29276 29268 -8
- Misses 13419 13427 +8
- Partials 697 698 +1
Continue to review full report at Codecov.
|
|
I guess the question is whether we should support the 0.3.x series or just 3.0. Changing this will break anybody that uses old MRtrix3 but new Nipype. Perhaps the better option would be to put a |
effigies
reviewed
Dec 22, 2018
There was a problem hiding this comment.
Ah, sorry. I know I suggested using numeric literals, but it looks like the convention is strings. (I think it'll be coerced to a string anyway, but just for consistency's sake...)
If you could also merge master and make specs again, I think this should be just about ready to go.
effigies
changed the title
Co-Authored-By: jguillon <[email protected]>
Co-Authored-By: jguillon <[email protected]>
…on/nipype into fix/mrtrix3-tckgen-option
|
@jguillon Could you merge current master. I think that should fix the tests. |
yarikoptic
added a commit
to yarikoptic/nipype
that referenced
this pull request
Feb 4, 2019
1.1.8 (January 28, 2019) * FIX: ANTS LaplacianThickness cmdline opts fixed up (nipy#2846) * FIX: Resolve LinAlgError during SVD (nipy#2838) * ENH: Add interfaces wrapping DIPY worflows (nipy#2830) * ENH: Update BIDSDataGrabber for pybids 0.7 (nipy#2737) * ENH: Add FSL `eddy_quad` interface (nipy#2825) * ENH: Support tckgen -select in MRtrix3 v3+ (nipy#2823) * ENH: Support for BIDS event files (nipy#2845) * ENH: CompositeTransformUtil, new ANTs interface (nipy#2785) * RF: Move pytest and pytest-xdist from general requirement into tests_required (nipy#2850) * DOC: Add S3DataGrabber example (nipy#2849) * DOC: Skip conftest module in API generation (nipy#2852) * DOC: Hyperlink DOIs to preferred resolver (nipy#2833) * MAINT: Install numpy!=1.16.0 from conda in Docker (nipy#2862) * MAINT: Drop pytest-xdist requirement, minimum pytest version (nipy#2856) * MAINT: Disable numpy 1.16.0 for Py2.7 (nipy#2855) * tag '1.1.8': (79 commits) MNT: Add @feilong to .zenodo, update ordering MNT: Update .mailmap MNT: Update .zenodo ordering Accept invitation as Zenodo release co-author (see nipy#2864) MAINT: Update .mailmap BF: allowing bids_event_file as alternate input MNT: Update .zenodo ordering MNT: Version 1.1.8 DOC: 1.1.8 changelog Update nipype/interfaces/dipy/tracks.py Update nipype/interfaces/dipy/reconstruction.py MNT: Install numpy!=1.16.0 from conda in Docker Add FSL auto test remake specs Update nipype/interfaces/io.py Remove return type named tuple Update nipype/info.py STY: Whitespace, line length Remove out_ prefix from EddyQuad outputs Apply minor edits from code review ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2821 .
List of changes proposed in this PR (pull-request)
tckgenoption from-numberto-selectAcknowledgment