Update tabcontents.yaml fix URL redirect http -> https #744
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -89,7 +89,7 @@ params: | |||
| alttext: A computer chip. | |||
| img: /images/content_images/sc_dom_img/quantum_computing.svg | |||
| links: | |||
| - url: http://qutip.org | |||
| - url: https://qutip.org | |||
There was a problem hiding this comment.
@steppi could you please have a look at this?
There was a problem hiding this comment.
Sorry. I'm not sure how I missed the pings back in April. This url has made it into content/ja/tabcontents.yaml and content/pt/tabcontents/yaml now
numpy.org/content/ja/tabcontents.yaml
Lines 102 to 103 in f9a497c
numpy.org/content/pt/tabcontents.yaml
Line 87 in f9a497c
The mechanism for keeping translations up to date is that updates to the source content propagate to Crowdin through the GitHub integration and translators get notified that there is new or updated content to translate. The updates made in Crowdin are pushed to the running branch l10n_main and we have a GitHub action which essentially cherry picks commits from this branch to create PRs for particular languages.
Process-wise, it would be fine either to just update the url in content/en/tabcontents.yaml and let the other updates be made by translators through Crowdin, or to make the change for all of the translated urls directly in GitHub. Originally, we had Crowdin configured in such a way that made it difficult to resolve conflicts when changes are made outside of Crowdin but that isn't an issue any more.
In this particular case, I think it's better the change http -> https directly in GitHub for the different languages, since this isn't really something that should require translator attention. As an aside, I want to figure out how to hide things like urls and other strings which should not be translated from the translators.
fix URL redirect http -> https
|
Thanks @partev! |
fix URL redirect http -> https
Brief description of what is fixed or changed