Skip to content

Update tabcontents.yaml fix URL redirect http -> https #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update tabcontents.yaml fix URL redirect http -> https #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63155e7
Update tabcontents.yaml
partev Apr 12, 2024
9fb24e6
Update link in other languages too
stefanv Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/tabcontents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ params:
alttext: A computer chip.
img: /images/content_images/sc_dom_img/quantum_computing.svg
links:
- url: http://qutip.org
- url: https://qutip.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgommers @steppi It looks like this isn't in content/pt/tabcontents.yaml or content/ja/tabcontents.yaml. Is there a plan or mechanism to keep the translations up-to-date?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steppi could you please have a look at this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steppi Gentle ping.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I'm not sure how I missed the pings back in April. This url has made it into content/ja/tabcontents.yaml and content/pt/tabcontents/yaml now

numpy.org/content/ja/tabcontents.yaml

Lines 102 to 103 in f9a497c

url: http://qutip.org
label: QuTiP

numpy.org/content/pt/tabcontents.yaml

Line 87 in f9a497c

- url: http://qutip.org

The mechanism for keeping translations up to date is that updates to the source content propagate to Crowdin through the GitHub integration and translators get notified that there is new or updated content to translate. The updates made in Crowdin are pushed to the running branch l10n_main and we have a GitHub action which essentially cherry picks commits from this branch to create PRs for particular languages.

Process-wise, it would be fine either to just update the url in content/en/tabcontents.yaml and let the other updates be made by translators through Crowdin, or to make the change for all of the translated urls directly in GitHub. Originally, we had Crowdin configured in such a way that made it difficult to resolve conflicts when changes are made outside of Crowdin but that isn't an issue any more.

In this particular case, I think it's better the change http -> https directly in GitHub for the different languages, since this isn't really something that should require translator attention. As an aside, I want to figure out how to hide things like urls and other strings which should not be translated from the translators.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Albert!

label: QuTiP
- url: https://pyquil-docs.rigetti.com/en/stable
label: PyQuil
Expand Down
2 changes: 1 addition & 1 deletion content/es/tabcontents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ params:
alttext: Un chip para computador.
img: /images/content_images/sc_dom_img/quantum_computing.svg
links:
- url: http://qutip.org
- url: https://qutip.org
label: QuTiP
- url: https://pyquil-docs.rigetti.com/en/stable
label: PyQuil
Expand Down
2 changes: 1 addition & 1 deletion content/ja/tabcontents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ params:
img: /images/content_images/sc_dom_img/quantum_computing.svg
links:
-
url: http://qutip.org
url: https://qutip.org
label: QuTiP
-
url: https://pyquil-docs.rigetti.com/en/stable
Expand Down
2 changes: 1 addition & 1 deletion content/pt/tabcontents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ params:
alttext: Um chip de computador.
img: /images/content_images/sc_dom_img/quantum_computing.svg
links:
- url: http://qutip.org
- url: https://qutip.org
label: QuTiP
- url: https://pyquil-docs.rigetti.com/en/stable
label: PyQuil
Expand Down