Mbostock/xlsx tweaks #254
Merged
Mbostock/xlsx tweaks #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Sep 15, 2021
mbostock
commented
Sep 15, 2021
mbostock
commented
Sep 15, 2021
mbostock
commented
Sep 15, 2021
visnup
reviewed
Sep 15, 2021
visnup
reviewed
Sep 15, 2021
visnup
reviewed
Sep 15, 2021
visnup
reviewed
Sep 15, 2021
visnup
force-pushed
the
mbostock/xlsx-tweaks
branch
from
74c9445 to
4193b19
Compare
visnup
force-pushed
the
mbostock/xlsx-tweaks
branch
from
4193b19 to
fe6a1b4
Compare
* Use Object.create(null) * Prefer public ExcelJS APIs * Use latest tap API
mbostock
commented
Sep 16, 2021
Co-authored-by: Mike Bostock <[email protected]>
visnup
approved these changes
Sep 16, 2021
|
Going to merge now and deal with all the version bumping and publishing tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.