Skip to content

Prefer public ExcelJS APIs #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Prefer public ExcelJS APIs #255

merged 4 commits into from
Sep 16, 2021

Conversation

visnup
Copy link
Member

@visnup visnup commented Sep 15, 2021

Is ExcelJS as a devDependency ok? There was a previous risk in using a mockWorkbook function in tests previously and this guarantees better compatibility. But it's a whole new library to bring in.

@visnup visnup requested a review from mbostock September 15, 2021 20:46
@visnup visnup mentioned this pull request Sep 15, 2021
@visnup visnup force-pushed the mbostock/xlsx-tweaks branch 2 times, most recently from 4193b19 to fe6a1b4 Compare September 15, 2021 22:02
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@visnup visnup merged commit 4cede49 into mbostock/xlsx-tweaks Sep 16, 2021
@visnup visnup deleted the visnup/xlsx-tweaks branch September 16, 2021 04:55
visnup added a commit that referenced this pull request Sep 16, 2021
* Update xlsx.js

* Update xlsx.js

* Use Object.create(null)

* Prefer public ExcelJS APIs (#255)

* Use Object.create(null)

* Prefer public ExcelJS APIs

* Use latest tap API

* Coerce header row values to strings before fallback check

* Update src/xlsx.js

Co-authored-by: Mike Bostock <[email protected]>

* Public API

Co-authored-by: Visnu Pitiyanuvath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants