for issue 429

[ramvikrams]

• Closes Nightly build appears to be broken #429
• Tests added: Please use assert_type() to assert the type of any return value

[Dr-Irv]

See here:

pandas-stubs/tests/test_resampler.py

Line 304 in 97dfaa9

FutureWarning, match="Not prepending group keys", upper="1.5.99"

for an example of how to use pytest_warns_bounds. You need to specify the upper parameter

[ramvikrams]

See here:

pandas-stubs/tests/test_resampler.py

Line 304 in 97dfaa9

FutureWarning, match="Not prepending group keys", upper="1.5.99"

for an example of how to use pytest_warns_bounds. You need to specify the upper parameter

Yes sir

[ramvikrams]

See here:

pandas-stubs/tests/test_resampler.py

Line 304 in 97dfaa9

FutureWarning, match="Not prepending group keys", upper="1.5.99"

for an example of how to use pytest_warns_bounds. You need to specify the upper parameter

Yes sir

Still not getting the checks passed after adding upper

[Dr-Irv]

Still not getting the checks passed after adding upper

Use pytest_warns_bounds() not python_warns_bounds(). When checks fail, look at the results of the checks to see the error messages.

But before you push, you should test locally by running poetry run poe test to see if the tests pass on your machine

[ramvikrams]

Still not getting the checks passed after adding upper

Use pytest_warns_bounds() not python_warns_bounds(). When checks fail, look at the results of the checks to see the error messages.

But before you push, you should test locally by running poetry run poe test to see if the tests pass on your machine

Yes sir

[ramvikrams]

It is still saying undefined name pytest_warns_bounds

[Dr-Irv]

It is still saying undefined name pytest_warns_bounds

It means you didn't import it. Look at other examples. This is basic python programming.

[ramvikrams]

It is still saying undefined name pytest_warns_bounds

It means you didn't import it. Look at other examples. This is basic python programming.

Sir what is the module to import pytest_warns_bounds i coudn't find it.

[Dr-Irv]

It is still saying undefined name pytest_warns_bounds

It means you didn't import it. Look at other examples. This is basic python programming.

Sir what is the module to import pytest_warns_bounds i coudn't find it.

Sorry it is pytest_warns_bounded not pytest_warns_bounds . Look at test_frame.py for an example

[ramvikrams]

It is still saying undefined name pytest_warns_bounds

It means you didn't import it. Look at other examples. This is basic python programming.

Sir what is the module to import pytest_warns_bounds i coudn't find it.

Sorry it is pytest_warns_bounded not pytest_warns_bounds . Look at test_frame.py for an example

yes sir

[ramvikrams]

Done sir

[Dr-Irv]

You changed WAY too many tests. Only change the ones listed in the original issue.

[ramvikrams]

You changed WAY too many tests. Only change the ones listed in the original issue.

yes sir

[ramvikrams]

You changed WAY too many tests. Only change the ones listed in the original issue.

Done sir

[Dr-Irv]

This is trickier than I thought. You have to look at the 6 failures in the nightly CI and we have to put in something where if the pandas version is larger than the bound specified, we catch an exception rather than trap a warning. I think the right solution is to modify the implementation of pytest_warns_bounded to return a different context manager if the version of pandas is >= the upper bound such that the context manager is trapping the exception. Use contextlib.supprress() and you'd have to pass in the expected exception type.

This is non-trivial. I'm not sure you will be able to do it. If not, let me know, and I will take this over.

[ramvikrams]

contextlib.supprress()

I think it would be better if you take over.

[Dr-Irv]

closing in favor of #436

[ramvikrams]

closing in favor of #436

yes sir