Fix nightly tests #436
Merged
Fix nightly tests #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Nov 24, 2022
pyproject.toml
Outdated
| @@ -37,7 +37,7 @@ types-pytz = ">= 2022.1.1" | |||
| mypy = "0.990" | |||
| pyarrow = ">=9.0.0" | |||
| pytest = ">=7.1.2" | |||
| pyright = ">=1.1.278" | |||
| pyright = "<=1.1.279" | |||
There was a problem hiding this comment.
Maybe add a pyright issue number, if it exists
There was a problem hiding this comment.
Latest main uses pyright >= 1.1.281, so this is resolved.
twoertwein
approved these changes
Nov 24, 2022
|
@bashtage or @twoertwein this is now good to go. Can one of you merge? |
|
Good to have this in. |
|
Nightly will probably be breaking a lot in the next few months unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #433, which was a starting point
Added tests to catch exceptions
Also avoid pyright 1.1.280 because it has bugs