Skip to content

BUG: Correct Escaping for LaTeX, #20859 #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

retkowski
Copy link
Contributor

@retkowski retkowski commented Apr 29, 2018

@pep8speaks
Copy link

pep8speaks commented Apr 29, 2018

Hello @ScientiaEtVeritas! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on April 29, 2018 at 20:28 Hours UTC

@retkowski retkowski force-pushed the bug-latex-escaping branch from 761c16d to 3d2255f Compare April 29, 2018 11:01
@retkowski retkowski force-pushed the bug-latex-escaping branch from 3d2255f to d92d76e Compare April 29, 2018 14:47
@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #20860 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20860      +/-   ##
==========================================
+ Coverage   91.77%   91.78%   +<.01%     
==========================================
  Files         153      153              
  Lines       49313    49313              
==========================================
+ Hits        45259    45261       +2     
+ Misses       4054     4052       -2
Flag Coverage Δ
#multiple 90.17% <100%> (ø) ⬆️
#single 41.88% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 100% <100%> (ø) ⬆️
pandas/util/testing.py 84.59% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563a6ad...d0ec214. Read the comment docs.

@TomAugspurger TomAugspurger added the IO LaTeX to_latex label Apr 29, 2018
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this in pandas/tests/io/formats/test_to_latext.py`?

@jreback jreback added this to the 0.23.0 milestone Apr 29, 2018
@jreback
Copy link
Contributor

jreback commented Apr 29, 2018

looks ok to me. @toobaz @TomAugspurger

@TomAugspurger TomAugspurger merged commit fe0d8db into pandas-dev:master Apr 30, 2018
@TomAugspurger
Copy link
Contributor

Thanks @ScientiaEtVeritas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO LaTeX to_latex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Wrong Latex Encoding
4 participants