CLN: Remove unused imports in pyx files #21802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. merge on green. |
|
@jbrockmendel Feel free to push directly to this PR. |
mroeschke
commented
Jul 8, 2018
| @@ -38,14 +38,13 @@ import pytz | |||
|
|
|||
|
|
|||
| from tslibs.timedeltas cimport cast_from_unit | |||
| from tslibs.timedeltas import Timedelta, ints_to_pytimedelta # noqa:F841 | |||
There was a problem hiding this comment.
Just to document, pandas.__init__ essentially grabs Timedelta from here (via pandas._libs.__init__). I think the fix is just to make sure Timedelta is directly grabbed from pandas/_libs/tslibs/timedeltas.pyx
Merged
|
Closing in favor of #21816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jbrockmendel
Removed unused imports flagged by PyCharm. Compiled fine locally, waiting for CI to pass.