Skip to content

update tslibs imports #21816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2018
Merged

update tslibs imports #21816

merged 2 commits into from
Jul 9, 2018

Conversation

jbrockmendel
Copy link
Member

Another try at #21802. Removing Timedelta from the tslib namespace broke a ton of imports, so this goes through and updates all of them.

@mroeschke
Copy link
Member

Linting error pandas/core/resample.py:27:1: F401 'pandas._libs.tslib' imported but unused otherwise LGTM

@codecov
Copy link

codecov bot commented Jul 8, 2018

Codecov Report

Merging #21816 into master will decrease coverage by <.01%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21816      +/-   ##
==========================================
- Coverage    91.9%    91.9%   -0.01%     
==========================================
  Files         160      160              
  Lines       49892    49891       -1     
==========================================
- Hits        45852    45851       -1     
  Misses       4040     4040
Flag Coverage Δ
#multiple 90.28% <96.96%> (-0.01%) ⬇️
#single 42.1% <55.55%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/errors/__init__.py 92.3% <100%> (ø) ⬆️
pandas/core/resample.py 96.07% <100%> (ø) ⬆️
pandas/tseries/frequencies.py 95.9% <100%> (ø) ⬆️
pandas/io/json/json.py 92.47% <100%> (ø) ⬆️
pandas/core/internals.py 95.46% <100%> (-0.01%) ⬇️
pandas/core/tools/timedeltas.py 98.41% <100%> (ø) ⬆️
pandas/core/series.py 94.2% <100%> (ø) ⬆️
pandas/core/dtypes/missing.py 92.52% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.2% <100%> (ø) ⬆️
pandas/core/arrays/timedelta.py 87.65% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec07ea8...6545d87. Read the comment docs.

@jreback jreback added Datetime Datetime data dtype Clean labels Jul 8, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 9, 2018
@jreback jreback merged commit 8e51fd3 into pandas-dev:master Jul 9, 2018
@jreback
Copy link
Contributor

jreback commented Jul 9, 2018

thanks!

@jbrockmendel jbrockmendel deleted the cnp1 branch July 11, 2018 20:21
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants